feat: add StatTile trend indicator#166
Open
webmirroring wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
delta?: numberandtrend?: "up" | "down" | "flat"props toStatTile.Up +N,Down -N,Flat 0) while preserving the existing<dt>/<dd>structure and unchanged default rendering.StatTiletests for no-delta, positive, negative, flat, and explicit-trend cases.Closes #149.
Accessibility notes
The trend indicator does not rely on color alone: the visible badge includes direction text, and the badge also includes
sr-onlyscreen-reader copy.Validation
node node_modules/jest/bin/jest.js src/components/__tests__/StatTile.test.tsx --runInBandpassesnode node_modules/jest/bin/jest.js src/components/__tests__ --runInBandpassesnode node_modules/jest/bin/jest.js --runInBandpasses: 23 suites, 119 testsnode node_modules/typescript/bin/tsc --noEmitpassesnode node_modules/next/dist/bin/next lintpassesnode node_modules/next/dist/bin/next buildpasses