Conversation
The GitHub update path (release feed probe and tauri-plugin-updater download) used to force a direct connection via no_proxy() whenever the in-app proxy was disabled, ignoring OS proxy settings entirely and breaking updates in environments where GitHub is unreachable directly. Update egress now resolves in order: app proxy when enabled (invalid config still fails fast), otherwise reqwest's default proxy detection (proxy env vars plus macOS/Windows system proxy settings via the system-proxy feature), otherwise direct. All other egress points keep the explicit no_proxy semantics; the now-unused async client_builder() is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tauri-plugin-updaterdownload) used to force a direct connection viano_proxy()whenever the in-app proxy was disabled, ignoring OS proxy settings entirely — updates failed in environments where GitHub is unreachable directly.system-proxydetection) → direct connection.client_builder_with_os_proxy_fallback()inservices/system_proxy.rsas the dedicated entry point for the update path;build_updater()no longer calls.no_proxy()so the plugin's internal client picks up the same fallback (verified against plugin source; single shared reqwest 0.13.4 build in the lockfile keeps thesystem-proxyfeature enabled for it).client_builder()is removed.Testing
cargo check --libclean (no warnings).cargo test --lib system_proxy8/8 andupdate::tests5/5 pass.