Skip to content

feat(popover): add compound popover atom#244

Merged
egdev6 merged 3 commits into
mainfrom
feat/26-popover
May 30, 2026
Merged

feat(popover): add compound popover atom#244
egdev6 merged 3 commits into
mainfrom
feat/26-popover

Conversation

@egdev6
Copy link
Copy Markdown
Member

@egdev6 egdev6 commented May 30, 2026

Summary

  • Add the compound Popover atom API backed by Radix Popover
  • Cover size/variant placement behavior, accessibility naming, dark-scope portal styling, reduced motion, and Storybook examples
  • Export Popover from the package root and add @radix-ui/react-popover

Related Issue

Closes #26

Checklist

  • I have read the contribution guidelines
  • I have updated documentation where needed
  • I have added tests for new behavior
  • I have run the test suite
  • I have verified Storybook builds successfully

@egdev6 egdev6 added the type:feature Feature changes label May 30, 2026
@egdev6 egdev6 self-assigned this May 30, 2026
@egdev6 egdev6 added this to the MVP milestone May 30, 2026
@egdev6 egdev6 requested a review from Copilot May 30, 2026 02:01
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new compound Popover atom backed by Radix Popover, with styling, accessibility naming, stories, tests, and package exports.

Changes:

  • Introduces Popover compound API with trigger/content/slot hooks and variants.
  • Adds Storybook examples and Vitest coverage for behavior, accessibility, placement, dark portal scope, and controlled state.
  • Adds @radix-ui/react-popover dependency and exports the atom from the package root.

Reviewed changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/components/atoms/popover/Popover.tsx Defines the compound Popover components and Radix integration.
src/components/atoms/popover/usePopover.ts Adds Popover state, trigger composition, content props, and slot hooks.
src/components/atoms/popover/types.ts Defines Popover variants, prop types, and compound API typing.
src/components/atoms/popover/Popover.test.tsx Adds hook and component behavior tests.
src/components/atoms/popover/Popover.stories.tsx Adds Storybook documentation and examples.
src/components/atoms/popover/index.ts Re-exports Popover and types.
src/styles/theme.css Adds reduced-motion handling for popover content.
src/index.ts Exports Popover from the package root.
package.json Adds Radix Popover dependency.
pnpm-lock.yaml Locks the new dependency and related resolution metadata.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/components/atoms/popover/usePopover.ts
@egdev6 egdev6 merged commit 4b8361e into main May 30, 2026
9 checks passed
@egdev6 egdev6 deleted the feat/26-popover branch May 30, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:feature Feature changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ATOMS] PopOver

2 participants