feat(harness): enforce prop default docs#248
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@defaultJSDoc intypes.ts.Closes #247
Review scope
scripts/verify-prop-default-docs.mjs.atl/skills/**component contributor/auditor contract updates.github/workflows/test.yml.github/workflows/storybook-build.ymllefthook.ymltypes.tsJSDoc metadata updatesType of change
Workflow gates
Closes #NNNor maintainer approved an exception.status:approvedbefore implementation starts.In progress, branch/worktree recorded.<type>(<optional scope>): <description>..playwright-mcp,page-*.png,page-*.jpeg,*.md.playwright-output.Component evidence (required for component changes)
N/A — this PR changes component public prop documentation metadata only; no runtime component implementation changed.
Accessibility evidence
N/A — no runtime UI behavior changed.
Validation evidence
pnpm exec tsc --noEmitpassed via lefthook pre-commit.pnpm testpassed via lefthook pre-push — 28 files, 440 tests.node scripts/verify-prop-default-docs.mjspassed.pnpm exec biome check <changed relevant files>passed via lefthook and manual validation..github/workflows/test.ymland.github/workflows/storybook-build.ymlparsed as YAML locally.Screenshots or recordings
N/A — metadata/tooling change only.
Notes for reviewer
The verifier intentionally checks literal/defaultable cases and avoids broad semantic inference for complex derived values. It covers:
defaultVariants;disabled ?? isDisabled ?? false.