chore(deps-dev): bump react, react-dom and @types/react#253
Conversation
Bumps [react](https://github.com/facebook/react/tree/HEAD/packages/react), [react-dom](https://github.com/facebook/react/tree/HEAD/packages/react-dom) and [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react). These dependencies needed to be updated together. Updates `react` from 18.3.1 to 19.2.7 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.7/packages/react) Updates `react-dom` from 18.3.1 to 19.2.7 - [Release notes](https://github.com/facebook/react/releases) - [Changelog](https://github.com/facebook/react/blob/main/CHANGELOG.md) - [Commits](https://github.com/facebook/react/commits/v19.2.7/packages/react-dom) Updates `@types/react` from 18.3.18 to 19.2.16 - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: react dependency-version: 19.2.7 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: react-dom dependency-version: 19.2.7 dependency-type: direct:development update-type: version-update:semver-major - dependency-name: "@types/react" dependency-version: 19.2.16 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
egdev6
left a comment
There was a problem hiding this comment.
Gracias por el update. El scope está limpio y las validaciones principales pasan, pero no lo podemos mergear todavía.
Hay un bloqueo de compatibilidad en los typings: el PR sube react y react-dom a 19.2.7, y @types/react a 19.2.16, pero deja @types/react-dom en 18.3.5. Para un salto major a React 19, ese paquete también debería moverse a la línea 19.x y regenerar el lockfile.
Además, sigue fallando Security / Dependency audit por vitest <4.1.0 (GHSA-5xrq-8626-4rwp). Ese bloqueo parece repo-wide, no específico de este PR, pero mientras branch protection exija ese check en verde no deberíamos mergear.
Pedido de cambio:
- Actualizar
@types/react-doma 19.x, por ejemplo19.2.3, y regenerarpnpm-lock.yaml. - Rerun CI.
- Aportar evidencia de
pnpm buildotsc --project tsconfig.build.json, porque este es un upgrade major de React/types y queremos cubrir la generación de declarations. - Resolver o dejar explícitamente aceptado el bloqueo existente de audit por
vitest, según la política del repo.
There was a problem hiding this comment.
Pull request overview
Updates the design system’s development React stack to React 19, aligning react, react-dom, and @types/react versions in package.json and refreshing the lockfile accordingly.
Changes:
- Bump
reactandreact-domfrom18.3.1to19.2.7 - Bump
@types/reactfrom18.3.18to19.2.16 - Regenerate
pnpm-lock.yamlto reflect the new dependency graph
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates devDependency versions for react, react-dom, and @types/react. |
| pnpm-lock.yaml | Updates locked React-related packages and transitive dependencies to match the new versions. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
egdev6
left a comment
There was a problem hiding this comment.
Cambios verificados en dfb322b.
@types/react-domquedó alineado en19.2.3con React 19.vitesty@vitest/coverage-v8subieron a4.1.8, resolviendo el bloqueo high/critical del audit repo-wide.- Se agregaron ajustes mínimos de tipos para React 19: refs nullable, narrowing de
child.propsy timeout ref en Select.
Validación local:
pnpm audit --audit-level highcon pnpm 10.34.1: sin high/critical, quedan solo moderates.pnpm test: 30 files / 538 tests passing con Vitest 4.1.8.pnpm run build: Vite build +tsc --project tsconfig.build.jsonpassing.
CI también quedó verde en audit, tests Ubuntu/Windows, Storybook, a11y y secrets scan.
|
Sumé los dos hardening que pediste:
Además el check descubrió un problema real del paquete generado: las declarations salían con imports de aliases internos y con el CSS side-effect import. Agregué Validado localmente con pnpm 10.34.1:
|
Bumps react, react-dom and @types/react. These dependencies needed to be updated together.
Updates
reactfrom 18.3.1 to 19.2.7Release notes
Sourced from react's releases.
... (truncated)
Changelog
Sourced from react's changelog.
... (truncated)
Commits
6117d7cVersion 19.2.7 (#36591)eaf3e95Version 19.2.623f4f9f19.2.590ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.15667a41Bump next prerelease version numbers (#34639)8bb7241Bump useEffectEvent to Canary (#34610)e3c9656Ensure Performance Track are Clamped and Don't overlap (#34509)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react since your current version.
Updates
react-domfrom 18.3.1 to 19.2.7Release notes
Sourced from react-dom's releases.
... (truncated)
Changelog
Sourced from react-dom's changelog.
... (truncated)
Commits
6117d7cVersion 19.2.7 (#36591)eaf3e95Version 19.2.623f4f9f19.2.590ab3f8Version 19.2.4612e371Version 19.2.3b910fc1Version 19.2.2053df4eVersion 19.2.18618113Bump scheduler version (#34671)1bd1f01Ship partial-prerendering APIs to Canary (#34633)2f0649a[Fizz] Removenonceoption from resume-and-prerender APIs (#34664)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for react-dom since your current version.
Updates
@types/reactfrom 18.3.18 to 19.2.16Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)