feat(ENG-12256): add unified connector building skill#4
Conversation
Consolidate 6 unified connector skills from connectors-template into a single comprehensive skill with reference files. This reduces repetition, eliminates contradictions, and follows the marketplace skill patterns. New skill: stackone-unified-connectors - Main SKILL.md with 9-step workflow and core principles - Reference files for field mapping, pagination, and scope patterns Also updates: - Bump version to 2.1.0 - Add unified-connectors and connector-development tags - Add Related Skills section to stackone-cli Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Adds a new consolidated “unified connector building” skill (with reference docs) and updates marketplace/plugin metadata to reflect the new capability.
Changes:
- Introduces
stackone-unified-connectorsskill with a 9-step workflow and three reference guides (field mapping, pagination, scopes). - Updates plugin/marketplace versions to
2.1.0and adds new tags (unified-connectors,connector-development). - Adds a “Related Skills” section to
stackone-clilinking to the new skill.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| skills/stackone-unified-connectors/SKILL.md | New unified connector workflow skill (core guidance + examples) |
| skills/stackone-unified-connectors/references/field-mapping-patterns.md | New reference for mapping/enum patterns |
| skills/stackone-unified-connectors/references/pagination-patterns.md | New reference for pagination configuration/testing |
| skills/stackone-unified-connectors/references/scope-patterns.md | New reference for scope definition patterns/tradeoffs |
| skills/stackone-cli/SKILL.md | Adds Related Skills section referencing unified connectors skill |
| .claude-plugin/plugin.json | Version bump + description/tag updates |
| .claude-plugin/marketplace.json | Version bump + tag updates |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
skills/stackone-unified-connectors/references/pagination-patterns.md
Outdated
Show resolved
Hide resolved
skills/stackone-unified-connectors/references/pagination-patterns.md
Outdated
Show resolved
Hide resolved
skills/stackone-unified-connectors/references/scope-patterns.md
Outdated
Show resolved
Hide resolved
skills/stackone-unified-connectors/references/field-mapping-patterns.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
cubic analysis
5 issues found across 7 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="skills/stackone-unified-connectors/SKILL.md">
<violation number="1" location="skills/stackone-unified-connectors/SKILL.md:103">
P2: The schema-skill discovery glob misses directory-based skills (`.../<skill>/SKILL.md`), so existing schema skills may not be detected.</violation>
<violation number="2" location="skills/stackone-unified-connectors/SKILL.md:213">
P2: The pagination example references `typecast_data` in `result.data` even though that step is not defined in the snippet.</violation>
</file>
<file name="skills/stackone-unified-connectors/references/pagination-patterns.md">
<violation number="1" location="skills/stackone-unified-connectors/references/pagination-patterns.md:54">
P2: The pagination example references `$.steps.typecast_data` even though no `typecast_data` step is defined, so the documented result mapping is broken.</violation>
<violation number="2" location="skills/stackone-unified-connectors/references/pagination-patterns.md:162">
P2: The test example uses `limit` instead of the declared input `page_size`, so it bypasses the pagination input wiring shown above.</violation>
</file>
<file name="skills/stackone-unified-connectors/references/field-mapping-patterns.md">
<violation number="1" location="skills/stackone-unified-connectors/references/field-mapping-patterns.md:62">
P2: The case-insensitive enum example can throw when `status` is null because `.toLowerCase()` is called without a guard.</violation>
</file>
Linked issue analysis
Linked issue: ENG-12256: Copy across the new connector-template skills to the plugin marketplace for external + agent harness for internal
| Status | Acceptance criteria | Notes |
|---|---|---|
| ✅ | Add new skill `stackone-unified-connectors` to the marketplace | Added skills/stackone-unified-connectors/SKILL.md |
| Consolidate 6 unified connector skills into a single comprehensive skill with reference files | New unified skill added but no merges/removals shown | |
| ✅ | Main SKILL.md contains 9-step workflow and core principles | SKILL.md includes 'Core Principles' and Step 1..Step 9 |
| ✅ | Add reference files for field mapping, pagination, and scope patterns | Reference files added under references/ |
| ✅ | Bump version to 2.1.0 in marketplace metadata | Version updated to 2.1.0 in metadata files |
| ✅ | Add `unified-connectors` and `connector-development` tags | Tags added in both marketplace.json and plugin.json |
| ✅ | Add Related Skills section to stackone-cli SKILL.md | Related Skills section inserted into stackone-cli SKILL.md |
| ✅ | Include Related Skills in new unified skill pointing to stackone-cli etc | Unified SKILL.md includes a 'Related Skills' section |
| ✅ | Update plugin.json description to mention unified connector development | plugin.json description updated to include unified connector development |
| ✅ | Update documentation to guide users which skills to plug in depending on building requirements | Added guidance in stackone-cli and unified skill docs |
| Make skills available for external marketplace and internal agent harness | Skills added under skills/ but no agent-harness config updates |
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
skills/stackone-unified-connectors/references/pagination-patterns.md
Outdated
Show resolved
Hide resolved
skills/stackone-unified-connectors/references/pagination-patterns.md
Outdated
Show resolved
Hide resolved
skills/stackone-unified-connectors/references/field-mapping-patterns.md
Outdated
Show resolved
Hide resolved
- Fix typecast_data references to get_data in pagination examples - Fix test param from limit to page_size to match input name - Standardize scope naming to employees:extended:read pattern - Add null guard to toLowerCase() in enum matching example - Update version to 2.1, fix CLI docs path references - Add Skill Architecture section explaining baseline/schema skill relationship - Add guidance for creating domain-specific schema skills - Update examples to show workflow with domain-specific skills Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Consolidate 6 unified connector skills from connectors-template into a single comprehensive skill with reference files. This reduces repetition, eliminates contradictions, and follows the marketplace skill patterns.
New skill: stackone-unified-connectors
Also updates:
Summary by cubic
Adds the
stackone-unified-connectorsbaseline skill to replace six templates with a single, clearer guide for unified connector builds. Updates marketplace metadata to v2.1.0 and clarifies how this baseline works with domain-specific schema skills, aligning with ENG-12256.New Features
stackone-unified-connectorswith a 9-step workflow, Core Principles, and a new Skill Architecture section explaining baseline vs domain schema skills, plus guidance for creating schema skills.unified-connectorsandconnector-developmenttags, and adds a Related Skills section instackone-cli.Bug Fixes
get_dataand input namepage_size) and fixes CLI docs links.employees:extended:readpattern and adds a null-safe enum matching example.Written for commit fafe5ae. Summary will update on new commits.