Skip to content

Plugin extra comment fixes#23

Merged
CameronCarlin merged 17 commits intomainfrom
plugin
Mar 23, 2026
Merged

Plugin extra comment fixes#23
CameronCarlin merged 17 commits intomainfrom
plugin

Conversation

@CameronCarlin
Copy link
Copy Markdown
Contributor

@CameronCarlin CameronCarlin commented Mar 23, 2026

Summary by cubic

Adds two Claude Code plugins to build Falcon connectors end to end and tightens setup, auth, and validation flow. Improves provider matching, clarifies custom-action validation, and fixes unified schema session handling.

  • New Features

    • stackone-connector-builder: interactive flow for generic connectors (setup, auth, discover, build, validate, test) with references for actions, auth, CLI, and connector patterns.
    • stackone-unified-builder: guided flow for choosing a unified schema and mapping fields; includes category schema refs (HRIS, ATS, CRM, LMS, IAM, Accounting, Documents, Marketing, Ticketing).
    • Commands: use /build-connector and /build-unified-connector (optional install: /plugin install stackone-unified-builder@stackone-claude-marketplace).
  • Bug Fixes

    • Auth: /configure-auth now explicitly supports custom or OAuth2; rule clarified that auth YAML can be written in Step 2.
    • Setup: switch to grep -ix "{{provider}}" when listing connectors to avoid false positives from substrings or hyphenated names.
    • Validation: clarified that custom actions don’t require entrypointUrl; ensure actionType: custom if this error appears.
    • Unified builder: import-schema now saves the provided provider to session and routes to /check-connector or /map-fields correctly.

Written for commit 7a09b40. Summary will update on new commits.

Copilot AI review requested due to automatic review settings March 23, 2026 14:33
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

7 issues found across 44 files

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name=".claude/plugins/stackone-connector-builder/skills/build-config/SKILL.md">

<violation number="1" location=".claude/plugins/stackone-connector-builder/skills/build-config/SKILL.md:182">
P2: The example uses duplicate `$ref` keys under `actions`, so only the last one would be retained in YAML. Use a list of refs (or unique keys) so multiple partials are included.</violation>
</file>

<file name=".claude/plugins/stackone-connector-builder/skills/stackone-connector-builder/SKILL.md">

<violation number="1" location=".claude/plugins/stackone-connector-builder/skills/stackone-connector-builder/SKILL.md:18">
P2: Quick Reference omits `custom` auth, which is documented as supported for `/configure-auth`.</violation>

<violation number="2" location=".claude/plugins/stackone-connector-builder/skills/stackone-connector-builder/SKILL.md:50">
P1: Step 2 instruction conflicts with the Rule that YAML must not be written until Step 4.</violation>
</file>

<file name=".claude/plugins/stackone-unified-builder/references/field-mapping-guide.md">

<violation number="1" location=".claude/plugins/stackone-unified-builder/references/field-mapping-guide.md:1">
P3: The entire file is wrapped in a Markdown code fence, so the content will render as a single code block instead of headings and lists. Remove the outer fences.</violation>
</file>

<file name=".claude/plugins/stackone-unified-builder/references/schemas/iam.md">

<violation number="1" location=".claude/plugins/stackone-unified-builder/references/schemas/iam.md:134">
P2: `updated_at` in `IamUser` is incorrectly documented as the creation date; it should describe the last update timestamp.</violation>
</file>

<file name=".claude/plugins/stackone-unified-builder/references/schemas/hris.md">

<violation number="1" location=".claude/plugins/stackone-unified-builder/references/schemas/hris.md:731">
P3: The `initial_balance` description is truncated (`sta...`), so the field meaning is only partially documented.</violation>
</file>

<file name=".claude/plugins/stackone-unified-builder/skills/test-connector/SKILL.md">

<violation number="1" location=".claude/plugins/stackone-unified-builder/skills/test-connector/SKILL.md:91">
P2: The debug command omits the `unified_{{action}}_{{resource}}` action name format used elsewhere, so it will likely fail to run the intended action. Use the same unified action naming here.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces new example connector YAMLs and adds two Claude Code plugins (stackone-unified-builder and stackone-connector-builder) with skill documentation and schema/reference material to support building StackOne Falcon connectors.

Changes:

  • Add BambooHR and Ashby example connector configurations under examples/.
  • Add a new stackone-unified-builder plugin with guided skills (choose schema → validate → test) plus unified schema reference docs.
  • Add a new stackone-connector-builder plugin for building non-unified (raw-response) connectors.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Show a summary per file
File Description
examples/bamboo-hr/bamboo-hr.employees.s1.partial.yaml Adds BambooHR employee actions (custom/raw style).
examples/bamboo-hr/bamboo-hr.connector.s1.yaml Adds BambooHR example connector definition referencing the employees partial.
examples/ashby/ashby.connector.s1.yaml Adds Ashby example connector definition (currently missing actions: wrapper for $ref).
.claude/settings.local.json Adds Claude local permissions configuration (likely should not be versioned).
.claude/plugins/stackone-unified-builder/skills/validate-connector/SKILL.md Adds unified-builder validation step instructions.
.claude/plugins/stackone-unified-builder/skills/test-connector/SKILL.md Adds unified-builder live testing step instructions.
.claude/plugins/stackone-unified-builder/skills/stackone-unified-builder/SKILL.md Adds unified-builder orchestration/wizard documentation.
.claude/plugins/stackone-unified-builder/skills/scope-actions/SKILL.md Adds action scoping step documentation for unified-builder.
.claude/plugins/stackone-unified-builder/skills/map-fields/SKILL.md Adds field mapping step documentation for unified-builder.
.claude/plugins/stackone-unified-builder/skills/import-schema/SKILL.md Adds schema import step documentation for unified-builder.
.claude/plugins/stackone-unified-builder/skills/choose-schema/SKILL.md Adds schema selection step documentation for unified-builder.
.claude/plugins/stackone-unified-builder/skills/check-connector/SKILL.md Adds connector existence/scaffold step documentation for unified-builder.
.claude/plugins/stackone-unified-builder/references/unified-schemas.md Adds unified category index reference.
.claude/plugins/stackone-unified-builder/references/schemas/marketing.md Adds marketing schema reference content.
.claude/plugins/stackone-unified-builder/references/schemas/lms.md Adds LMS schema reference content.
.claude/plugins/stackone-unified-builder/references/schemas/iam.md Adds IAM schema reference content.
.claude/plugins/stackone-unified-builder/references/schemas/documents.md Adds documents schema reference content.
.claude/plugins/stackone-unified-builder/references/schemas/crm.md Adds CRM schema reference content.
.claude/plugins/stackone-unified-builder/references/schemas/accounting.md Adds accounting schema reference content.
.claude/plugins/stackone-unified-builder/references/field-mapping-guide.md Adds field mapping guide (currently wrapped in an outer code fence).
.claude/plugins/stackone-unified-builder/references/connector-patterns.md Adds canonical connector/action YAML patterns reference for unified-builder.
.claude/plugins/stackone-unified-builder/references/cli-commands.md Adds CLI usage reference for unified-builder.
.claude/plugins/stackone-unified-builder/references/auth-patterns.md Adds auth pattern reference for unified-builder.
.claude/plugins/stackone-unified-builder/references/actions-and-steps.md Adds actions/steps reference for unified-builder.
.claude/plugins/stackone-unified-builder/README.md Adds unified-builder plugin README.
.claude/plugins/stackone-unified-builder/.claude-plugin/plugin.json Adds unified-builder plugin manifest.
.claude/plugins/stackone-connector-builder/skills/validate-connector/SKILL.md Adds generic connector validation step instructions.
.claude/plugins/stackone-connector-builder/skills/test-connector/SKILL.md Adds generic connector live testing + cleanup instructions.
.claude/plugins/stackone-connector-builder/skills/stackone-connector-builder/SKILL.md Adds generic connector builder wizard documentation.
.claude/plugins/stackone-connector-builder/skills/setup-connector/SKILL.md Adds setup step documentation for generic connector builder.
.claude/plugins/stackone-connector-builder/skills/discover-actions/SKILL.md Adds action discovery step documentation for generic connector builder.
.claude/plugins/stackone-connector-builder/skills/configure-auth/SKILL.md Adds auth configuration step documentation for generic connector builder.
.claude/plugins/stackone-connector-builder/skills/build-config/SKILL.md Adds config generation step documentation for generic connector builder.
.claude/plugins/stackone-connector-builder/references/connector-patterns.md Adds canonical connector/action YAML patterns reference for generic builder.
.claude/plugins/stackone-connector-builder/references/cli-commands.md Adds CLI usage reference for generic builder.
.claude/plugins/stackone-connector-builder/references/auth-patterns.md Adds auth pattern reference for generic builder.
.claude/plugins/stackone-connector-builder/references/actions-and-steps.md Adds actions/steps reference for generic builder.
.claude/plugins/stackone-connector-builder/README.md Adds generic connector builder plugin README.
.claude/plugins/stackone-connector-builder/.claude-plugin/plugin.json Adds generic connector builder plugin manifest.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

The description for the `/configure-auth` command in the
`stackone-connector-builder` skill was updated to be more specific about
the supported authentication types (custom or OAuth2).
@CameronCarlin CameronCarlin merged commit b1c4fc9 into main Mar 23, 2026
5 checks passed
@CameronCarlin CameronCarlin deleted the plugin branch March 23, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants