-
Notifications
You must be signed in to change notification settings - Fork 1
fix(ENG-12465): use absolute URLs for README images to fix npm display #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
c393242
fix: upgrade ML classifier to jbv2 (AgentShield 73.7 → 79.8)
hiskudin 8814745
chore(biome): add model files in biome ignore
hiskudin 0ff4bed
chore(biome): add model files in biome ignore
hiskudin 738787b
fix: use absolute URLs for README images to fix npm display
hiskudin 18a1bd6
Merge branch 'main' into fix/readme-npm-image-paths
hiskudin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These image URLs are pinned to the
mainbranch on GitHub. That makes the README for older published npm versions non-deterministic (images can change or break if assets move). Consider pinning to a release tag/commit SHA (or a CDN URL that includes a tag) so the npm README stays stable per package version.