feat(ENG-12176): Add auth config selection step with actions and account counts#109
feat(ENG-12176): Add auth config selection step with actions and account counts#109joeStackOne wants to merge 7 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an intermediate “auth config selection” step to the integration picker flow, showing per-auth-config stats (accounts/actions) and action details before proceeding to the credential form.
Changes:
- Introduces provider-first selection (deduped connector list), followed by auth config selection per provider.
- Fetches provider actions metadata and enriches auth config cards with action counts/details.
- Updates picker title/content/back-navigation logic to support the new step.
Reviewed changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/modules/integration-picker/types.ts | Adds action/provider action response types and new Integration metadata fields. |
| src/modules/integration-picker/queries.ts | Adds getProviderActions API query. |
| src/modules/integration-picker/hooks/useIntegrationPicker.ts | Adds provider selection state, provider action query, and derived lists for provider/auth-config steps. |
| src/modules/integration-picker/components/views/index.ts | Exports the new auth config selection view. |
| src/modules/integration-picker/components/views/AuthConfigSelectionView.tsx | New UI for selecting an auth config and viewing actions/stats. |
| src/modules/integration-picker/components/IntegrationPickerTitle.tsx | Updates header/title logic for provider vs auth-config steps. |
| src/modules/integration-picker/components/IntegrationPickerContent.tsx | Adds routing between provider list → auth config selection → form. |
| src/modules/integration-picker/IntegrationPicker.tsx | Wires new state/handlers into title/content and updates back behavior. |
| package.json | Removes @stackone/malachite from dependencies. |
| package-lock.json | Removes @stackone/malachite and transitive deps from lockfile. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/modules/integration-picker/components/views/AuthConfigSelectionView.tsx
Outdated
Show resolved
Hide resolved
src/modules/integration-picker/components/views/AuthConfigSelectionView.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="src/modules/integration-picker/components/views/AuthConfigSelectionView.tsx">
<violation number="1" location="src/modules/integration-picker/components/views/AuthConfigSelectionView.tsx:91">
P2: Disable the Select action for inactive auth configs; currently configs marked "Disabled" can still be selected.</violation>
</file>
<file name="src/modules/integration-picker/hooks/useIntegrationPicker.ts">
<violation number="1" location="src/modules/integration-picker/hooks/useIntegrationPicker.ts:294">
P2: Deduplicating providers before filtering active integrations can hide valid providers when an inactive config appears first.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
src/modules/integration-picker/components/views/AuthConfigSelectionView.tsx
Show resolved
Hide resolved
src/modules/integration-picker/components/views/AuthConfigSelectionView.tsx
Show resolved
Hide resolved
adefreitas
left a comment
There was a problem hiding this comment.
Blocking this for now, I need to understand what the task is about but there are things here that I don't think below to the hub, in the meantime a couple of things
- you shouldn't be able to create an auth config from the hub only the dashboard should care about those things
- we shouldn't do any extra requests or heavy computation in the hub, the API should send whatever we need already built
|
The auth config selection has been moved from the hub to the dashboard. |
Summary by cubic
Adds a provider‑first auth config selection step in the integration picker. Users now choose a provider, pick an auth config with clear action/account info, then complete the form. Addresses ENG-12176.
AuthConfigSelectionViewwith cards showing auth type/label, version, enabled status, action count, and account count; expandable actions table with names and descriptions.uniqueProviderIntegrations) → provider’s auth configs (providerIntegrations) → form; auto‑selects when only one active integration.getProviderActions; match by provider key + version to enrich config cards.connectorKeyandconnectorVersionwhen available.Written for commit 03c73a9. Summary will update on new commits.