fix: move @tanstack/react-query to devDependencies#122
Open
mstrivens wants to merge 1 commit intoStackOneHQ:mainfrom
Open
fix: move @tanstack/react-query to devDependencies#122mstrivens wants to merge 1 commit intoStackOneHQ:mainfrom
mstrivens wants to merge 1 commit intoStackOneHQ:mainfrom
Conversation
React-query is bundled into the dist output (not externalized in rollup.config.mjs), so consumers don't need it in their dependency tree. Having it as a regular dependency causes pnpm to hoist query-core@5, breaking type resolution for projects using react-query v4. Fixes #5663 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
React-query is bundled into the dist output (not externalized in rollup.config.mjs), so consumers don't need it in their dependency tree.
Having it as a regular dependency causes pnpm to hoist query-core@5, breaking type resolution for projects using react-query v4.
Fixes #5663
Summary by cubic
Moved
@tanstack/react-queryfrom dependencies to devDependencies because it’s bundled in the dist and not required by consumers. This prevents pnpm from hoistingquery-core@5and fixes type resolution for projects using@tanstack/react-queryv4.Written for commit 60d2e98. Summary will update on new commits.