Skip to content

fix: ignore changelog from oxfmt #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryoppippi merged 2 commits into from
Dec 15, 2025
Merged

fix: ignore changelog from oxfmt #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42b5ad2
fix(rule): biome -> oxlint
ryoppippi Dec 15, 2025
6e0cf19
chore(oxfmt): ignore changelog
ryoppippi Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .claude/rules/pnpm-usage.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ This rule provides guidance on using pnpm in the StackOne SDK.

## Code Quality

- `pnpm lint` - Run Biome linter
- `pnpm format` - Format code with Biome
- `pnpm lint` - Run oxfmt/oxlint/knip linter
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is misleading. The lint command runs oxfmt in check mode, oxlint, and knip, but only oxlint is actually a linter. oxfmt is a formatter (in check mode here), and knip detects unused code. A more accurate description would be "Run code quality checks with oxfmt/oxlint/knip" or similar.

Suggested change
- `pnpm lint` - Run oxfmt/oxlint/knip linter
- `pnpm lint` - Run code quality checks with oxfmt/oxlint/knip

Copilot uses AI. Check for mistakes.
- `pnpm format` - Format code with oxfmt/oxlint/knip
Copy link

Copilot AI Dec 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description is inaccurate. The format command formats code with oxfmt, not with oxfmt/oxlint/knip as stated. According to package.json, the format command runs oxfmt for formatting, oxlint with --fix flag, and knip with --fix flag. Only oxfmt is a code formatter - oxlint is a linter (though it can auto-fix some issues), and knip is a tool for detecting unused code. The description should be more accurate about what these tools do, such as "Format code and apply auto-fixes with oxfmt/oxlint/knip".

Suggested change
- `pnpm format` - Format code with oxfmt/oxlint/knip
- `pnpm format` - Format code and apply auto-fixes with oxfmt/oxlint/knip

Copilot uses AI. Check for mistakes.

## Command Execution

Expand Down
2 changes: 1 addition & 1 deletion .oxfmtrc.jsonc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,5 @@
"useTabs": true,
"semi": true,
"singleQuote": true,
"ignorePatterns": [".claude/settings.local.json"],
"ignorePatterns": [".claude/settings.local.json", "CHANGELOG.md"],
}
Loading