chore(nix): remove redundant tsgolint and add nix-workflow rule#297
chore(nix): remove redundant tsgolint and add nix-workflow rule#297
Conversation
The tsgolint binary is bundled with the oxlint package in nixpkgs, so specifying it separately is unnecessary. This removes the duplicate from both flake.nix and CI workflow.
Add comprehensive documentation for Nix usage in the project: - Development environment setup with flake.nix - CI workflow using nix profile install via setup-nix action - Tool configuration and adding new packages - Build flags for local development This helps maintain consistency when modifying Nix configuration.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
These tools are not used by pnpm lint (only oxfmt, oxlint, knip).
There was a problem hiding this comment.
Pull request overview
This PR removes the redundant tsgolint package from the Nix development environment configuration and CI workflow, as it is bundled with oxlint. Additionally, it adds comprehensive documentation for Nix-related workflows in a new Claude rule file.
Changes:
- Removed
tsgolintfromflake.nixbuildInputs and CI workflow tools - Added
nix-workflow.mdrule documenting Nix development environment and CI setup patterns - Updated
CLAUDE.mdto reference the newnix-workflowrule
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| flake.nix | Removed redundant tsgolint package from buildInputs |
| .github/workflows/ci.yaml | Removed tsgolint from CI lint job tools list |
| CLAUDE.md | Added reference to new nix-workflow rule in the rules table |
| .claude/rules/nix-workflow.md | New documentation file for Nix development environment and CI patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Nix Workflow | ||
|
|
||
| This rule provides guidance on Nix usage in the StackOne SDK. |
There was a problem hiding this comment.
The new nix-workflow.md file is missing the YAML frontmatter that other rule files in this directory include. Add frontmatter with 'description' and 'alwaysApply' fields to maintain consistency with other rules like development-workflow.md and pnpm-usage.md.
commit: |
Summary
tsgolintpackage from flake.nix and CI workflow (bundled withoxlint).claude/rules/nix-workflow.mddocumenting Nix configuration patternsTest plan
tsgolintsince it's included inoxlintSummary by cubic
Removed redundant tsgolint (bundled in oxlint) from flake.nix and CI and dropped unused similarity/nixfmt from the lint job. Added a Nix workflow rule for the dev env, CI setup, and Nix build commands.
Written for commit 004f471. Summary will update on new commits.