Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the TypeScript Go (tsgo) tool from an npm package to a Nix package. The @typescript/native-preview npm package is being removed as a direct dependency and replaced with the typescript-go package from nixpkgs.
Changes:
- Removed
@typescript/native-previewfrom npm dependencies (package.json, pnpm-workspace.yaml) - Updated pnpm-lock.yaml to mark the package as optional (since it remains as a transitive dependency through tsdown)
- Added
typescript-goto the Nix development environment (flake.nix)
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| pnpm-workspace.yaml | Removed @typescript/native-preview from the catalog of dependencies |
| pnpm-lock.yaml | Removed package from catalog and importers sections, marked as optional in snapshots since it remains as a transitive dependency |
| package.json | Removed @typescript/native-preview from devDependencies |
| flake.nix | Added typescript-go to the Nix development environment buildInputs |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Moved tsgo to the Nix dev shell so it’s installed and versioned via Nix instead of npm. Also removed the unused @typescript/native-preview to trim dev dependencies.
Written for commit dfd5166. Summary will update on new commits.