Skip to content

Refactored third party API detection to improve consistency #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mrpopo911 wants to merge 1 commit into
base: master
Choose a base branch
from
+10 −8
Open

Refactored third party API detection to improve consistency #137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/extension_shield/api/scoring_legacy.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,12 @@


# ── Permission-Purpose Alignment (context-aware model) ──────────────────
def is_third_party_api(check_id: str) -> bool:
if not check_id:
return False
check_id = check_id.lower()
keywords = ["third_party", "external_api", "api_call", "network"]
return any(keyword in check_id for keyword in keywords)

def _calculate_permission_alignment_penalty(
manifest: Dict,
Expand Down Expand Up @@ -116,12 +122,12 @@ def _calculate_permission_alignment_penalty(
for findings_list in sast_findings.values():
for finding in findings_list:
check_id = finding.get("check_id", "")
if "third_party" in check_id.lower() or "external_api" in check_id.lower():
if check_id and any(keyword in check_id.lower() for keyword in ["third_party", "external_api", "api_call", "network"]): #Change1
has_third_party_api = True
break
if has_third_party_api:
break

covert_multiplier = 1.0
if has_cookies or has_history or has_clipboard:
covert_multiplier = 2.0

Expand Down Expand Up @@ -173,7 +179,7 @@ def calculate_security_score(state: WorkflowState) -> int:
for findings_list in sast_findings.values():
for finding in findings_list:
check_id = finding.get("check_id", "")
if "third_party" in check_id.lower() or "external_api" in check_id.lower():
if is_third_party_api(check_id):
continue
severity = finding.get("extra", {}).get("severity", "INFO").upper()
if severity in ("CRITICAL", "HIGH"):
Expand Down Expand Up @@ -256,11 +262,7 @@ def calculate_security_score(state: WorkflowState) -> int:
for findings_list in sast_findings.values():
for finding in findings_list:
check_id = finding.get("check_id", "")
if check_id and (
"banking.third_party.external_api_calls" in check_id
or "third_party" in check_id.lower()
or "external_api" in check_id.lower()
):
if is_third_party_api(check_id):
third_party_detected = True
break
if third_party_detected:
Expand Down