Skip to content

fix: improve RainfallDroplets color consistency, animation behavior, and accessibility #173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gauravsingh001-cyber wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve RainfallDroplets color consistency, animation behavior, and accessibility #173

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 3 additions & 17 deletions frontend/src/components/RainfallDroplets/RainfallDroplets.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,26 +15,12 @@ function buildDropletConfig(count, durationMin, durationMax, opacityMin, opacity
id: i,
left: 5 + (i * 5.5) % 90,
delay: (i * 0.4) % 5,
duration: durationMin + (i % 3) * ((durationMax - durationMin) / 3),
duration: durationMin + Math.random() * (durationMax - durationMin), // ✅ improved
size: 4 + (i % 3) * 2,
opacity: opacityMin + (i % 4) * ((opacityMax - opacityMin) / 4),
}));
}

/**
* RainfallDroplets – reusable falling-droplets background animation.
* Renders a layer of animated droplets falling from top to bottom.
*
* @param {Object} props
* @param {number} [props.count=18] - Number of droplets
* @param {string} [props.color] - CSS color for droplets (default: accent green)
* @param {string} [props.className] - Extra class for the wrapper
* @param {number} [props.zIndex=0] - z-index of the layer
* @param {number} [props.durationMin=3.5] - Min animation duration (s)
* @param {number} [props.durationMax=5.9] - Max animation duration (s)
* @param {number} [props.opacityMin=0.4] - Min droplet opacity
* @param {number} [props.opacityMax=0.85] - Max droplet opacity
*/
const RainfallDroplets = ({
count = DEFAULT_COUNT,
color,
Expand All @@ -59,7 +45,7 @@ const RainfallDroplets = ({
<div
className={`rainfall-droplets ${className}`.trim()}
style={wrapperStyle}
aria-hidden
aria-hidden="true" // ✅ fixed
>
{config.map(({ id, left, delay, duration, size, opacity }) => (
<span
Expand All @@ -79,4 +65,4 @@ const RainfallDroplets = ({
);
};

export default RainfallDroplets;
export default RainfallDroplets;
19 changes: 12 additions & 7 deletions frontend/src/components/RainfallDroplets/RainfallDroplets.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
/* ============================================================================
RainfallDroplets – reusable falling droplets background
Use on any page that needs the rainfall animation.
============================================================================ */

.rainfall-droplets {
position: absolute;
inset: 0;
Expand All @@ -18,10 +13,20 @@
transform: translateX(-50%);
border-radius: 50%;
background: var(--rainfall-droplet-color);
box-shadow: 0 0 12px rgba(34, 197, 94, 0.5);


box-shadow: 0 0 12px var(--rainfall-droplet-color);

animation: rainfall-droplet-fall linear infinite;
}


@media (prefers-reduced-motion: reduce) {
.rainfall-droplets__droplet {
animation: none;
}
}

@keyframes rainfall-droplet-fall {
0% {
transform: translateX(-50%) translateY(0);
Expand All @@ -31,4 +36,4 @@
transform: translateX(-50%) translateY(120vh);
opacity: 0.2;
}
}
}