Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# ExtensionShield CI/CD Pipeline
# Deploys to Railway on push to main

name: Deploy to Railway
name: Deploy to Render
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Update remaining Railway references in comments to avoid config drift.

The workflow/job names were correctly moved to Render, but nearby file comments still say Railway (e.g., Line 2 and Line 96). Please align those comments with the new deployment target.

Also applies to: 99-99

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/deploy.yml at line 4, Update any leftover comments that
still reference "Railway" so they consistently refer to "Render"; search for
comment text containing the word "Railway" near the workflow header (the YAML
key name: Deploy to Render) and elsewhere in the file (including the comment
block near the end that previously referenced Railway) and replace those comment
strings with "Render" to avoid config drift.


on:
push:
Expand Down Expand Up @@ -96,7 +96,7 @@ jobs:
# Job 3: Deploy to Railway
# =============================================================================
deploy:
name: Deploy to Railway
name: Deploy to Render
runs-on: ubuntu-latest
needs: build
if: github.event_name == 'push' && github.ref == 'refs/heads/main'
Expand All @@ -105,18 +105,14 @@ jobs:
- name: Checkout code
uses: actions/checkout@v4

- name: Install Railway CLI
run: npm install -g @railway/cli

- name: Deploy to Railway
run: railway up --detach
env:
RAILWAY_TOKEN: ${{ secrets.RAILWAY_TOKEN }}
- name: Trigger Render Deploy Hook
run: |
curl -f -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"
Comment on lines +108 to +110
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Harden deploy-hook call with timeout and retry controls.

This external call currently has no timeout/retry strategy, so transient network issues can cause flaky or stalled deploy jobs.

🔧 Proposed patch
       - name: Trigger Render Deploy Hook
         run: |
-          curl -f -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"
+          curl --fail --silent --show-error \
+            --retry 3 --retry-delay 2 --retry-all-errors \
+            --connect-timeout 10 --max-time 60 \
+            -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- name: Trigger Render Deploy Hook
run: |
curl -f -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"
- name: Trigger Render Deploy Hook
run: |
curl --fail --silent --show-error \
--retry 3 --retry-delay 2 --retry-all-errors \
--connect-timeout 10 --max-time 60 \
-X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In @.github/workflows/deploy.yml around lines 108 - 110, Update the "Trigger
Render Deploy Hook" step's curl invocation to include network timeouts and retry
controls: replace the bare curl -f -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"
with a hardened curl that sets a connect timeout, overall max time, and retry
policy (for example: --connect-timeout 10 --max-time 30 --retry 3 --retry-delay
5 --retry-connrefused -sS -f -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"), so
transient network issues are retried but the job fails quickly on persistent
errors while preserving the original non-zero exit behavior.


- name: Deployment Summary
run: |
echo "## 🚀 Deployment Complete!" >> $GITHUB_STEP_SUMMARY
echo "## 🚀 Deployment Triggered!" >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "Your app has been deployed to Railway." >> $GITHUB_STEP_SUMMARY
echo "A deployment request has been sent to Render." >> $GITHUB_STEP_SUMMARY
echo "" >> $GITHUB_STEP_SUMMARY
echo "Check your Railway dashboard for the live URL." >> $GITHUB_STEP_SUMMARY
echo "Check your Render dashboard to monitor the progress of the build and deployment." >> $GITHUB_STEP_SUMMARY
Loading
Loading