-
Notifications
You must be signed in to change notification settings - Fork 77
Fix/security vulnerabilities #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
f99c946
6988a92
6552de7
8c87a3a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,7 +1,7 @@ | ||||||||||||||||||||
| # ExtensionShield CI/CD Pipeline | ||||||||||||||||||||
| # Deploys to Railway on push to main | ||||||||||||||||||||
|
|
||||||||||||||||||||
| name: Deploy to Railway | ||||||||||||||||||||
| name: Deploy to Render | ||||||||||||||||||||
|
|
||||||||||||||||||||
| on: | ||||||||||||||||||||
| push: | ||||||||||||||||||||
|
|
@@ -96,7 +96,7 @@ jobs: | |||||||||||||||||||
| # Job 3: Deploy to Railway | ||||||||||||||||||||
| # ============================================================================= | ||||||||||||||||||||
| deploy: | ||||||||||||||||||||
| name: Deploy to Railway | ||||||||||||||||||||
| name: Deploy to Render | ||||||||||||||||||||
| runs-on: ubuntu-latest | ||||||||||||||||||||
| needs: build | ||||||||||||||||||||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' | ||||||||||||||||||||
|
|
@@ -105,18 +105,14 @@ jobs: | |||||||||||||||||||
| - name: Checkout code | ||||||||||||||||||||
| uses: actions/checkout@v4 | ||||||||||||||||||||
|
|
||||||||||||||||||||
| - name: Install Railway CLI | ||||||||||||||||||||
| run: npm install -g @railway/cli | ||||||||||||||||||||
|
|
||||||||||||||||||||
| - name: Deploy to Railway | ||||||||||||||||||||
| run: railway up --detach | ||||||||||||||||||||
| env: | ||||||||||||||||||||
| RAILWAY_TOKEN: ${{ secrets.RAILWAY_TOKEN }} | ||||||||||||||||||||
| - name: Trigger Render Deploy Hook | ||||||||||||||||||||
| run: | | ||||||||||||||||||||
| curl -f -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}" | ||||||||||||||||||||
|
Comment on lines
+108
to
+110
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Harden deploy-hook call with timeout and retry controls. This external call currently has no timeout/retry strategy, so transient network issues can cause flaky or stalled deploy jobs. 🔧 Proposed patch - name: Trigger Render Deploy Hook
run: |
- curl -f -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"
+ curl --fail --silent --show-error \
+ --retry 3 --retry-delay 2 --retry-all-errors \
+ --connect-timeout 10 --max-time 60 \
+ -X GET "${{ secrets.RENDER_DEPLOY_HOOK }}"📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||||
|
|
||||||||||||||||||||
| - name: Deployment Summary | ||||||||||||||||||||
| run: | | ||||||||||||||||||||
| echo "## 🚀 Deployment Complete!" >> $GITHUB_STEP_SUMMARY | ||||||||||||||||||||
| echo "## 🚀 Deployment Triggered!" >> $GITHUB_STEP_SUMMARY | ||||||||||||||||||||
| echo "" >> $GITHUB_STEP_SUMMARY | ||||||||||||||||||||
| echo "Your app has been deployed to Railway." >> $GITHUB_STEP_SUMMARY | ||||||||||||||||||||
| echo "A deployment request has been sent to Render." >> $GITHUB_STEP_SUMMARY | ||||||||||||||||||||
| echo "" >> $GITHUB_STEP_SUMMARY | ||||||||||||||||||||
| echo "Check your Railway dashboard for the live URL." >> $GITHUB_STEP_SUMMARY | ||||||||||||||||||||
| echo "Check your Render dashboard to monitor the progress of the build and deployment." >> $GITHUB_STEP_SUMMARY | ||||||||||||||||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update remaining Railway references in comments to avoid config drift.
The workflow/job names were correctly moved to Render, but nearby file comments still say Railway (e.g., Line 2 and Line 96). Please align those comments with the new deployment target.
Also applies to: 99-99
🤖 Prompt for AI Agents