Skip to content

Fix/zip bomb limits #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amansingh1207 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix/zip bomb limits #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0c57781
fix: run container as non-root user to reduce attack
amansingh1207 Apr 4, 2026
ae7b7e3
fix: reduce ZIP bomb protection limits to prevent DoS
amansingh1207 Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,8 +88,14 @@ ENV PATH="/app/.venv/bin:$PATH"
# Copy frontend build from stage 1
COPY --from=frontend-builder /app/frontend/dist ./static

# Create necessary directories
RUN mkdir -p extensions_storage data
# Create necessary directories and non-root user
RUN mkdir -p extensions_storage data && \
addgroup --system appgroup && \
adduser --system --ingroup appgroup appuser && \
chown -R appuser:appgroup /app

# Drop root privileges
USER appuser

# Set default environment variables
ENV EXTENSION_STORAGE_PATH=/app/extensions_storage \
Expand Down
10 changes: 6 additions & 4 deletions src/extension_shield/core/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,16 +208,18 @@ def get_settings() -> Settings:
telemetry_admin_key = os.environ.get("TELEMETRY_ADMIN_KEY")

# Zip-bomb protection: max file count and max total uncompressed size
_zip_max_files = os.environ.get("ZIP_EXTRACT_MAX_FILES", "10000")
_zip_max_bytes = os.environ.get("ZIP_EXTRACT_MAX_UNCOMPRESSED_BYTES", "524288000") # 500 MiB
# Reduced defaults to prevent DoS via crafted .crx archives:
# 1000 files and 100 MiB are sufficient for any legitimate Chrome extension.
_zip_max_files = os.environ.get("ZIP_EXTRACT_MAX_FILES", "1000")
_zip_max_bytes = os.environ.get("ZIP_EXTRACT_MAX_UNCOMPRESSED_BYTES", "104857600") # 100 MiB
try:
zip_extract_max_files = int(_zip_max_files)
except ValueError:
zip_extract_max_files = 10000
zip_extract_max_files = 1000
try:
zip_extract_max_uncompressed_bytes = int(_zip_max_bytes)
except ValueError:
zip_extract_max_uncompressed_bytes = 524288000
zip_extract_max_uncompressed_bytes = 104857600

storage_backend = _parse_storage_backend(os.environ.get("STORAGE_BACKEND"))

Expand Down