Add update notification opt-out action#38
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a “Never Notify Again” action to update-available desktop notifications, routing the action through the running session notification service to persist updates.auto_check=disabled via the settings API (and disable the installed update-check timer). Also expands notification-action sender validation to accommodate GNOME Shell and adds tests for sender/trust and close/action ordering, plus corresponding documentation updates.
Changes:
- Add a
Never Notify Againnotification action that disables automatic update checks via the settings layer. - Refactor the session-bus notification handoff to use the internal
SessionBusClientabstraction and introduce request body (de)serialization helpers. - Update notification signal sender validation and add tests covering daemon owner, GNOME Shell sender, spoofed sender, and close/action race handling.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Documents the new opt-out action on update notifications. |
| docs/user-guide.md | Explains the new action behavior and how it maps to updates.auto_check=disabled. |
| docs/architecture-overview.md | Updates architecture notes for opt-out action routing/persistence. |
| crates/lg-buddy/src/session_notifications.rs | Implements the opt-out action, settings persistence hook, updated sender trust logic, and expanded tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+913
to
+918
| let mut owners = vec![current_bus_name_owner(connection, NOTIFICATION_SERVICE)?]; | ||
| if let Ok(owner) = current_bus_name_owner(connection, GNOME_SHELL_BUS_NAME) { | ||
| if !owners.contains(&owner) { | ||
| owners.push(owner); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Never Notify Againaction to actionable update notificationsupdates.auto_check=disabledthrough the settings APIPart of #27.
Validation
cargo fmt --check -p lg-buddycargo clippy -p lg-buddy --all-targets --all-features -- -D warningscargo test -p lg-buddy --all-targetsNotes
Manual cross-desktop testing still matters because notification action senders vary by desktop environment. A beta/RC testing callout should explain how to build with
LG_BUDDY_RELEASE_VERSION, how to trigger update notifications, how to clear or edit the update-check cache when repeated notifications are needed, and how to collectLG Buddy Sessionjournal diagnostics if action handling is rejected.