Fix crash on startup with KSA r3646#56
Closed
Maximilian-Nesslauer wants to merge 20 commits intoStarMapLoader:devfrom
Closed
Fix crash on startup with KSA r3646#56Maximilian-Nesslauer wants to merge 20 commits intoStarMapLoader:devfrom
Maximilian-Nesslauer wants to merge 20 commits intoStarMapLoader:devfrom
Conversation
Mods can implement the IStarMapOnUi to access OnBeforeUi and OnAfterUi which are called before and after the OnDrawUi of Program in KSA, this can be used to add or overwrite ui elements using ImGui
Fix package release
Version 0.1.5
Only publish API when there is a change
Switch interface to use attributes instead of interfaces
Force build API
Resolve issue in attribute resolution
Resolve mods never being unloaded
Fixed issue with StarMap.API forcing dummy KSA dll
Provide installer for StarMap
Fix installer pipeline
StarMapBeforeMainAttribute attribute + Fix issue with ALCs unloading after initialization
Fix interface use of ModLibrary (StarMapLoader#33)
Update to net10
Change actions to publish StarMap.API to nuget instead of github
Force build API (StarMapLoader#40)
Make the AssemblyLoadContexts not collectable (StarMapLoader#42)
Do not try to unload the assembly load contexts (StarMapLoader#44) Add StarMap hook for after onFrame
KSA r3646 added `Directory.SetCurrentDirectory(AppDomain.CurrentDomain.BaseDirectory)` at the top of Program.Main() to fix a Linux startup crash. When launched via StarMap, AppDomain.CurrentDomain.BaseDirectory resolves to StarMap's directory instead of the game directory, causing the game to look for assets in the wrong location. Fix by setting APP_CONTEXT_BASE_DIRECTORY to the game directory, which is the backing store for AppDomain.CurrentDomain.BaseDirectory in .NET. Fixes StarMapLoader#55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem: in KSA Version v2026.2.32.3646 (most likely commit https://discord.com/channels/1260011486735241329/1260112103134724146/1474293335723347999) added Directory.SetCurrentDirectory(AppDomain.CurrentDomain.BaseDirectory) at the top of Program.Main() in Program.cs to fix a Linux startup crash.
When StarMap launches KSA via reflection, AppDomain.CurrentDomain.BaseDirectory resolves to StarMap's install directory (not KSA's), because it's the same process/AppDomain.
StarMap already sets the CWD correctly, but KSA's new code immediately overrides it.
The fix sets
APP_CONTEXT_BASE_DIRECTORYto the game directory viaAppContext.SetData().This works because in .NET, AppDomain.CurrentDomain.BaseDirectory delegates to AppContext.BaseDirectory, which checks the APP_CONTEXT_BASE_DIRECTORY data store first before falling back to the process executable path.
By setting this to the game directory, KSA's Directory.SetCurrentDirectory(AppDomain.CurrentDomain.BaseDirectory) will now correctly resolve to the game directory even when launched through StarMap.
Tested and verified with KSA r3646 and StarMap 0.3.6
Fixes #55