Skip to content

Bug/pos invoice consolidation#6

Merged
dlw8 merged 2 commits intoversion-15from
bug/pos_invoice_consolidation
Dec 18, 2025
Merged

Bug/pos invoice consolidation#6
dlw8 merged 2 commits intoversion-15from
bug/pos_invoice_consolidation

Conversation

@filipestarktail
Copy link
Copy Markdown

Description

Fixed issue where POS Closing Entry could not be submitted. very small/minimal changes

Type of change

  • Bug fix (change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tests

  • Unit Tests have been updated or added, as required
  • UI Tests have been updated or added, as required

Checklist:

  • My code follows Naming Guidelines (DocType, Field and Variable naming)
  • No Form changes / My code follows the Form Design Guidelines
  • My code follows the Coding Standards of this project
  • My code follows the Code Security Guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas / No comments necessary
  • I have made corresponding additions/changes to the documentation
  • All business logic and validations are on the server-side / No business logic or validation changes
  • No patches are necessary / Migration Patches have been added to the correct subdirectory of /patches and patches.txt have been updated

User Experience:

N/A

Copy link
Copy Markdown

@dlw8 dlw8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@filipestarktail

Just a reminder, commit message / new branches should be prefixed with one of:

  • build
  • chore
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Most commonly:

  • fix (for bug fixes)
  • feat (new features)
  • chore (code updates that don't necessarily affect end users)

@dlw8 dlw8 merged commit a68cf3d into version-15 Dec 18, 2025
4 of 5 checks passed
@filipestarktail
Copy link
Copy Markdown
Author

@filipestarktail

Just a reminder, commit message / new branches should be prefixed with one of:

  • build
  • chore
  • ci
  • docs
  • feat
  • fix
  • perf
  • refactor
  • revert
  • style
  • test

Most commonly:

  • fix (for bug fixes)
  • feat (new features)
  • chore (code updates that don't necessarily affect end users)

Thank you @dlw8 Daniel. Sorry about that, its the second time I do it. I will make sure to build the habit of structuring my commits better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants