Skip to content

fix: handle UTF-8 BOM character in Bank Zero csv files #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dvdl16 merged 2 commits into from
Feb 24, 2026
Merged

fix: handle UTF-8 BOM character in Bank Zero csv files #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f18248b
fix: handle UTF-8 BOM character in Bank Zero csv files
dvdl16 Feb 24, 2026
44f489b
chore: bump to v0.3.1
dvdl16 Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion csf_za/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = "0.3.0"
__version__ = "0.3.1"
4 changes: 4 additions & 0 deletions csf_za/overrides/accounts/bank_statement_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,10 @@ def parse_csv_file_bankzero(self, file_doc):
"Balance",
"Has Attachments",
]
# remove UTF-8 BOM from first header cell if present
if data and data[0] and isinstance(data[0][0], str):
data[0][0] = data[0][0].lstrip("\ufeff")

if data[0][:9] != expected_headers[:9]:
frappe.throw(
_("Unexpected headers in CSV. Expected: {0} in first row").format(
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "csf_za",
"version": "0.3.0",
"version": "0.3.1",
"author": "Starktail (Pty) Ltd <support@starktail.com>",
"main": "index.js",
"devDependencies": {
Expand Down