Skip to content

Fix: pyi add missing staticmethod decorator and remove duplicate declaration#189

Merged
akshayballal95 merged 2 commits into
StarlightSearch:devfrom
DayNice:fix/signature
Nov 7, 2025
Merged

Fix: pyi add missing staticmethod decorator and remove duplicate declaration#189
akshayballal95 merged 2 commits into
StarlightSearch:devfrom
DayNice:fix/signature

Conversation

@DayNice

@DayNice DayNice commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

This PR fixes some issues where type checkers complain about.

Constructor typed as instance method

Image Image

Duplicate declarations

Image Image

@akshayballal95 akshayballal95 merged commit afcb6ad into StarlightSearch:dev Nov 7, 2025
5 checks passed
@akshayballal95

Copy link
Copy Markdown
Collaborator

Awesome. Thanks for the fix.

@DayNice DayNice deleted the fix/signature branch November 7, 2025 14:32
@DayNice

DayNice commented Dec 6, 2025

Copy link
Copy Markdown
Contributor Author

@akshayballal95 I just noticed that this PR was left out last time dev was merged to main. May I ask whether this was a simple mistake?

image

@akshayballal95

Copy link
Copy Markdown
Collaborator

Yes. Probably a mistake. Let me check

@akshayballal95

Copy link
Copy Markdown
Collaborator

Should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants