Set size_t to usize in build configuration#2
Open
luodeb wants to merge 1 commit intoStarry-OS:mainfrom
Open
Conversation
luodeb
commented
Nov 20, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bindgen compilation failure encountered during cross-compilation for 64-bit targets. The error occurred because bindgen detected that ssize_t was 4 bytes while the target platform had 8-byte pointers, causing an assertion failure.
- Adds
.size_t_is_usize(false)to the bindgen builder configuration to handle cross-compilation scenarios where C'ssize_tdoesn't match Rust's target pointer size
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Mivik
approved these changes
Nov 21, 2025
|
Which platform are you using to build this? We haven't encountered this problem before. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.