Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -77,12 +77,22 @@ const ethSignTypedDataV4: RpcRequestInput = {
],
}

const walletSignRawDigest: RpcRequestInput = {
method: 'wallet_signRawDigest',
params: [
{ key: 'digest', required: true },
{ key: 'address', required: true },
],
format: (data: Record<string, string>) => [data.digest, data.address],
}

export const signMessageMethods = [
ethSign,
personalSign,
ethSignTypedDataV1,
ethSignTypedDataV3,
ethSignTypedDataV4,
walletSignRawDigest,
]

export const verifySignMsg = async ({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,16 @@ const personalSignShortcuts: ShortcutType[] = [
},
]

const walletSignRawDigestShortcuts: ShortcutType[] = [
{
key: 'Example digest',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am getting error when using Example digest. I am running local Startale app from branch feat/support-strium-login

Image

data: {
digest: `0x${'ab'.repeat(32)}`,
address: ADDR_TO_FILL,
},
},
]

const ethSignTypedDataV1Shortcuts: ShortcutType[] = [
{
key: EXAMPLE_MESSAGE,
Expand Down Expand Up @@ -180,4 +190,5 @@ export const signMessageShortcutsMap = (chainId: number) => ({
eth_signTypedData_v1: ethSignTypedDataV1Shortcuts,
eth_signTypedData_v3: ethSignTypedDataV3Shortcuts(chainId),
eth_signTypedData_v4: ethSignTypedDataV4Shortcuts(chainId),
wallet_signRawDigest: walletSignRawDigestShortcuts,
})
7 changes: 6 additions & 1 deletion packages/app-sdk/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@
"import": "./dist/interface/public-utilities/spend-permission/index.js",
"require": "./dist/interface/public-utilities/spend-permission/index.js"
},
"./raw-digest-sign": {
"types": "./dist/interface/public-utilities/raw-digest-sign/index.d.ts",
"import": "./dist/interface/public-utilities/raw-digest-sign/index.js",
"require": "./dist/interface/public-utilities/raw-digest-sign/index.js"
},
Comment on lines +35 to +39
"./ui-assets": {
"types": "./dist/ui/assets/index.d.ts",
"import": "./dist/ui/assets/index.js",
Expand Down Expand Up @@ -117,4 +122,4 @@
"import": "*"
}
]
}
}
2 changes: 2 additions & 0 deletions packages/app-sdk/src/browser-entry.ts
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,8 @@ export type {
} from ':core/provider/interface.js'
export { createStartaleAccountSDK } from './interface/builder/core/createStartaleAccountSDK.js'
export { getCryptoKeyAccount, removeCryptoKey } from './kms/crypto-key/index.js'
export { requestSignRawDigest } from './interface/public-utilities/raw-digest-sign/index.js'
export type { RequestSignRawDigestType } from './interface/public-utilities/raw-digest-sign/index.js'
export { base, CHAIN_IDS, getPaymentStatus, pay, TOKENS }
export type {
InfoRequest,
Expand Down
4 changes: 4 additions & 0 deletions packages/app-sdk/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ export { createStartaleAccountSDK } from './interface/builder/core/createStartal

export { getCryptoKeyAccount, removeCryptoKey } from './kms/crypto-key/index.js'

// Raw digest sign interface exports
export { requestSignRawDigest } from './interface/public-utilities/raw-digest-sign/index.js'
export type { RequestSignRawDigestType } from './interface/public-utilities/raw-digest-sign/index.js'

// Payment interface exports
export { base, getPaymentStatus, pay } from './interface/payment/index.js'
export type {
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
import { describe, expect, it, vi } from 'vitest'

import { ProviderInterface } from ':core/provider/interface.js'
import { requestSignRawDigest } from './index.js'

describe('requestSignRawDigest', () => {
const address = '0x1234567890abcdef1234567890abcdef12345678' as const
const digest = `0x${'ab'.repeat(32)}` as const

const makeProvider = (returnValue: string): ProviderInterface =>
({
request: vi.fn().mockResolvedValue(returnValue),
}) as unknown as ProviderInterface

it('forwards a 32-byte digest to wallet_signRawDigest', async () => {
const provider = makeProvider('0xdeadbeef')

const signature = await requestSignRawDigest({
provider,
digest,
address,
})

expect(provider.request).toHaveBeenCalledWith({
method: 'wallet_signRawDigest',
params: [digest, address],
})
expect(signature).toBe('0xdeadbeef')
})

it('rejects digests that are not exactly 32 bytes', async () => {
const provider = makeProvider('0xdeadbeef')

await expect(
requestSignRawDigest({
provider,
digest: '0x1234' as `0x${string}`,
address,
}),
).rejects.toThrow('digest must be a 32-byte hex string')
expect(provider.request).not.toHaveBeenCalled()
})

it('rejects non-hex digests of the right length', async () => {
const provider = makeProvider('0xdeadbeef')

await expect(
requestSignRawDigest({
provider,
digest: `0x${'zz'.repeat(32)}` as `0x${string}`,
address,
}),
).rejects.toThrow('digest must be a 32-byte hex string')
})
})
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
import { type Address, type Hex } from 'viem'

import { ProviderInterface } from ':core/provider/interface.js'

export type RequestSignRawDigestType = {
provider: ProviderInterface
/** 32-byte signing digest (0x + 64 hex chars) */
digest: Hex
address: Address
}

const DIGEST_PATTERN = /^0x[0-9a-fA-F]{64}$/

/**
* Asks the popup to raw-sign a 32-byte digest with the user's embedded
* wallet (EOA) — plain secp256k1 ECDSA over the exact digest bytes, with no
* EIP-191 prefix and no re-hashing.
*
* The signature bytes vary across calls (MPC signing is non-deterministic),
* but `ecrecover(digest, signature)` always yields the same signer address.
* Callers should rely on the recovered key, never on signature stability.
*
* Typical use cases: recovering a stable user address via ecrecover, and
* signing externally-computed digests such as Substrate extrinsic payloads
* for ethereum-type (AccountId20) chains.
*/
const requestSignRawDigestFn = async ({

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do export requestSignRawDigest and remove the last line

provider,
digest,
address,
}: RequestSignRawDigestType): Promise<Hex> => {
if (!DIGEST_PATTERN.test(digest)) {
throw new Error(
'digest must be a 32-byte hex string (0x followed by 64 hex chars)',
)
}

const signature = (await provider.request({
method: 'wallet_signRawDigest',
params: [digest, address],
})) as Hex

return signature
}

export const requestSignRawDigest = requestSignRawDigestFn
1 change: 1 addition & 0 deletions packages/app-sdk/src/sign/app-sdk/Signer.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -449,6 +449,7 @@ describe('Signer', () => {
'eth_ecRecover',
'personal_sign',
'wallet_sign',
'wallet_signRawDigest',
'personal_ecRecover',
'eth_signTransaction',
'eth_sendTransaction',
Expand Down
1 change: 1 addition & 0 deletions packages/app-sdk/src/sign/app-sdk/Signer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,7 @@ export class Signer {
case 'eth_ecRecover':
case 'personal_sign':
case 'wallet_sign':
case 'wallet_signRawDigest':
case 'personal_ecRecover':
Comment on lines 269 to 273
case 'eth_signTransaction':
case 'eth_sendTransaction':
Expand Down
2 changes: 2 additions & 0 deletions packages/app-sdk/src/sign/app-sdk/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ describe('utils', () => {
['wallet_sendCalls', [{ from: sender }], sender],
['eth_signTypedData_v4', [sender, {}], sender],
['personal_sign', ['message', sender], sender],
['wallet_signRawDigest', ['message', sender], sender],
])(
'should return the sender from the request for %s',
(method, params, sender) => {
Expand All @@ -50,6 +51,7 @@ describe('utils', () => {
['wallet_sendCalls', [{}], [{ from: '0x123' }]],
['eth_signTypedData_v4', [undefined, {}], ['0x123', {}]],
['personal_sign', ['hello', undefined], ['hello', '0x123']],
['wallet_signRawDigest', ['hello', undefined], ['hello', '0x123']],
])(
'should enhance the request params for %s',
(method, params, expectedParams) => {
Expand Down
2 changes: 2 additions & 0 deletions packages/app-sdk/src/sign/app-sdk/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export function getSenderFromRequest(request: RequestArguments) {
}
switch (request.method) {
case 'personal_sign':
case 'wallet_signRawDigest':
return request.params[1] as Address
case 'eth_signTypedData_v4':
return request.params[0] as Address
Expand Down Expand Up @@ -67,6 +68,7 @@ export function addSenderToRequest(request: RequestArguments, sender: Address) {
params[0] = sender
break
case 'personal_sign':
case 'wallet_signRawDigest':
params[1] = sender
break
default:
Expand Down
Loading