Fixed archive inherits at folders#320
Fixed archive inherits at folders#320dibyanshu-pal-kushwaha wants to merge 2 commits intoStatTag:masterfrom
Conversation
lrasmus
left a comment
lrasmus
left a comment
There was a problem hiding this comment.
This is really, really great work. I'm not sure if it was on purpose, but this PR removes onDirtyStateChange from the project component, and I wasn't sure why. If you could double-check that was intentional, and if so please let me know why that removal is needed. Thanks!
| import styles from './Project.css'; | ||
| import UserContext from '../../contexts/User'; | ||
|
|
||
| type Props = { |
There was a problem hiding this comment.
Is there a reason onDirtyStateChange was removed?
There was a problem hiding this comment.
Sorry about that Sir , it was changed accidentally during making these changes... I have added onDirtyStateChange back into the code in the latest commit....
| project={this.props.project} | ||
| updates={this.props.logs ? this.props.logs.updates : null} | ||
| onClickUpdatesLink={this.clickUpdatesLinkHandler} | ||
| onDirtyStateChange={this.props.onDirtyStateChange} |
There was a problem hiding this comment.
Is there a reason onDirtyStateChange was removed?
There was a problem hiding this comment.
Reverted in the latest commit.
| onUpdated: PropTypes.func, | ||
| onAssetSelected: PropTypes.func, | ||
| onChecklistUpdated: PropTypes.func, | ||
| onDirtyStateChange: PropTypes.func, |
There was a problem hiding this comment.
Is there a reason onDirtyStateChange was removed?
There was a problem hiding this comment.
Reverted in the latest commit.
| onUpdated: null, | ||
| onAssetSelected: null, | ||
| onChecklistUpdated: null, | ||
| onDirtyStateChange: null, |
There was a problem hiding this comment.
Is there a reason onDirtyStateChange was removed?
There was a problem hiding this comment.
Reverted in the latest commit.
|
@lrasmus , I put back all changes , Please review this pr. |
2 participants
Description :
Currently , when we achive the Top folder , only it get archived not inherited to the all the descendants , and when we unarchive the top folder then all the already archived child files/folders remains archived. In this solution when you archive the Top folder , all the descendants get Archived and when we Unarchive the top folder , a popup pops out asking to Unarchive all the already descendants files/folder or keep them as it is.
Fixes
Fixes : #217
Changes :
Screen Recordings :
UnarchiveDescendants.mov