feat: implement milestone proposal and acceptance#168
Merged
Cedarich merged 8 commits intoStayLitCodes:mainfrom Mar 30, 2026
Merged
feat: implement milestone proposal and acceptance#168Cedarich merged 8 commits intoStayLitCodes:mainfrom
Cedarich merged 8 commits intoStayLitCodes:mainfrom
Conversation
Contributor
|
Fix failing workflow |
|
@ShantelPeters Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
Kindly review changes @Cedarich |
- fix(backend): replace req.user.sub with req.user.userId in escrow controller, events controller, and escrow access guard to match the actual JWT payload shape returned by AuthService.validateToken() - fix(frontend): remove root eslint.config.js that caused ERR_MODULE_NOT_FOUND for @typescript-eslint/eslint-plugin in frontend CI (each sub-project uses its own eslint config) - fix(stellar): make StellarModule @global() so EscrowStellarIntegrationService can resolve StellarService without importing StellarModule in EscrowModule - fix(escrow): remove StellarModule import from EscrowModule (now global) - fix(escrow-service): add duplicate dispute guard and fix EXISTS subquery syntax - fix(stellar-event-listener): implement OnModuleDestroy for clean shutdown - fix(auth): raise throttle limit in test environment to prevent test flakiness - fix(tests): remove obsolete escrow-scheduler e2e spec, add minimal e2e setup
Contributor
|
Please resolve conflicts |
Contributor
Author
|
hello @Cedarich conflicts has been resolved |
Contributor
Contributor
Author
|
Hi @Cedarich changes has been made , kindly review please |
Cedarich
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSES #135