Skip to content

Revert Microsoft.CodeAnalysis.CSharp to version 4.8.0 #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StefH merged 2 commits into from
Sep 4, 2025
Merged

Revert Microsoft.CodeAnalysis.CSharp to version 4.8.0 #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
57bc843
Revert Microsoft.CodeAnalysis.CSharp to version 4.8.0
StefH Aug 31, 2025
b1b484a
nugets
StefH Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions src/ProxyInterfaceSourceGenerator/ProxyInterfaceSourceGenerator.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,7 @@
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.Analyzers" Version="4.11.0">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.11.0" PrivateAssets="all" />
<PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.8.0" PrivateAssets="all" />
<PackageReference Include="Nullable" Version="1.3.1">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
Expand Down
2 changes: 1 addition & 1 deletion tests/ProxyInterfaceSourceGeneratorTests/AkkaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
using AwesomeAssertions;
using CSharp.SourceGenerators.Extensions;
using CSharp.SourceGenerators.Extensions.Models;
using CultureAwareTesting.xUnit;
using FluentAssertions;
using ProxyInterfaceSourceGenerator;
using ProxyInterfaceSourceGeneratorTests.Helpers;

Expand Down
319 changes: 196 additions & 123 deletions .../ProxyInterfaceSourceGeneratorTests/Destination/Microsoft.SharePoint.Client.WebProxy.g.cs
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions ...ceSourceGeneratorTests/Destination/ProxyInterfaceSourceGeneratorTests.Source.IPerson.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,12 +20,10 @@ public partial interface IPerson

global::System.Collections.Generic.List<global::ProxyInterfaceSourceGeneratorTests.Source.IHuman> Humans { get; set; }

[System.ComponentModel.DataAnnotations.DisplayAttribute(Prompt = "MyStruct Indexer")]
global::ProxyInterfaceSourceGeneratorTests.Source.MyStruct this[int i] { get; set; }

global::ProxyInterfaceSourceGeneratorTests.Source.MyStruct this[int i, string s] { get; set; }

[System.ComponentModel.DataAnnotations.DisplayAttribute(ResourceType = typeof(System.Threading.PeriodicTimer))]
string Name { get; set; }

string? StringNullable { get; set; }
Expand Down Expand Up @@ -66,7 +64,6 @@ public partial interface IPerson

global::System.Threading.Tasks.Task<int> Method2Async();

[System.ComponentModel.DataAnnotations.DisplayAttribute(Name = "M3")]
global::System.Threading.Tasks.Task<string?> Method3Async();

void CreateInvokeHttpClient(int i = 5, string? appId = null, global::System.Collections.Generic.IReadOnlyDictionary<string, string>? metadata = null, global::System.Threading.CancellationToken token = default(System.Threading.CancellationToken));
Expand Down
3 changes: 0 additions & 3 deletions ...urceGeneratorTests/Destination/ProxyInterfaceSourceGeneratorTests.Source.PersonProxy.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,10 @@ static PersonProxy()

public global::System.Collections.Generic.List<global::ProxyInterfaceSourceGeneratorTests.Source.IHuman> Humans { get => MapToInterface(_Instance.Humans); set => _Instance.Humans = MapToInstance(value); }

[System.ComponentModel.DataAnnotations.DisplayAttribute(Prompt = "MyStruct Indexer")]
public global::ProxyInterfaceSourceGeneratorTests.Source.MyStruct this[int i] { get => _Instance[i]; set => _Instance[i] = value; }

public global::ProxyInterfaceSourceGeneratorTests.Source.MyStruct this[int i, string s] { get => _Instance[i, s]; set => _Instance[i, s] = value; }

[System.ComponentModel.DataAnnotations.DisplayAttribute(ResourceType = typeof(System.Threading.PeriodicTimer))]
public string Name { get => _Instance.Name; set => _Instance.Name = value; }

public string? StringNullable { get => _Instance.StringNullable; set => _Instance.StringNullable = value!; }
Expand Down Expand Up @@ -186,7 +184,6 @@ public void In_Out_Ref1(in int a, out int b, ref int c)
return result__57677169;
}

[System.ComponentModel.DataAnnotations.DisplayAttribute(Name = "M3")]
public global::System.Threading.Tasks.Task<string?> Method3Async()
{
var result__57684656 = _Instance.Method3Async();
Expand Down
117 changes: 78 additions & 39 deletions ...eSourceGeneratorTests/Destination/ProxyInterfaceSourceGeneratorTests.Source.PnP.IWeb.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,12 @@ public partial interface IWeb
[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.FolderCollection Folders { get; }

[Microsoft.SharePoint.Client.RemoteAttribute]
int FooterColorIndexInDarkMode { get; set; }

[Microsoft.SharePoint.Client.RemoteAttribute]
int FooterColorIndexInLightMode { get; set; }

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.FooterVariantThemeType FooterEmphasis { get; set; }

Expand All @@ -181,6 +187,12 @@ public partial interface IWeb
[Microsoft.SharePoint.Client.RemoteAttribute]
bool HasWebTemplateExtension { get; set; }

[Microsoft.SharePoint.Client.RemoteAttribute]
int HeaderColorIndexInDarkMode { get; set; }

[Microsoft.SharePoint.Client.RemoteAttribute]
int HeaderColorIndexInLightMode { get; set; }

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.SPVariantThemeType HeaderEmphasis { get; set; }

Expand Down Expand Up @@ -281,7 +293,7 @@ public partial interface IWeb
bool PreviewFeaturesEnabled { get; }

[Microsoft.SharePoint.Client.RemoteAttribute]
string PrimaryColor { get; }
string PrimaryColor { get; set; }

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.PushNotificationSubscriberCollection PushNotificationSubscribers { get; }
Expand All @@ -298,6 +310,9 @@ public partial interface IWeb
[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.RegionalSettings RegionalSettings { get; }

[Microsoft.SharePoint.Client.RemoteAttribute]
string RelatedHubSiteIds { get; }

[Microsoft.SharePoint.Client.RemoteAttribute]
string RequestAccessEmail { get; set; }

Expand Down Expand Up @@ -361,6 +376,9 @@ public partial interface IWeb
[Microsoft.SharePoint.Client.RemoteAttribute]
bool TenantTagPolicyEnabled { get; }

[Microsoft.SharePoint.Client.RemoteAttribute]
string ThemeApplicationActionHistory { get; }

[Microsoft.SharePoint.Client.RemoteAttribute]
string ThemedCssFolderUrl { get; set; }

Expand Down Expand Up @@ -434,24 +452,6 @@ public partial interface IWeb
[Microsoft.SharePoint.Client.RemoteAttribute]
void CreateDefaultAssociatedGroups(string userLogin, string userLogin2, string groupNameSeed);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<string> CreateOrganizationSharingLink(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string url, bool isEditLink);

[Microsoft.SharePoint.Client.RemoteAttribute]
void DestroyOrganizationSharingLink(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string url, bool isEditLink, bool removeAssociatedSharingLinkGroup);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<global::Microsoft.SharePoint.Client.SharingLinkKind> GetSharingLinkKind(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string fileUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<global::Microsoft.SharePoint.Client.SharingLinkData> GetSharingLinkData(string linkUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<string> MapToIcon(string fileName, string progId, global::Microsoft.SharePoint.Client.Utilities.IconSize size);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<string> GetWebUrlFromPageUrl(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string pageFullUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.PushNotificationSubscriber RegisterPushNotificationSubscriber(global::System.Guid deviceAppInstanceId, string serviceToken);

Expand All @@ -470,6 +470,9 @@ public partial interface IWeb
[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.PushNotificationSubscriber GetPushNotificationSubscriber(global::System.Guid deviceAppInstanceId);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.SPLargeOperation GetListOperation(global::System.Guid listId, global::System.Guid operationId);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.User GetSiteUserIncludingDeletedByPuid(string puid);

Expand Down Expand Up @@ -512,6 +515,24 @@ public partial interface IWeb
[Microsoft.SharePoint.Client.RemoteAttribute]
void DeleteAnonymousLinkForObject(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string url, bool isEditLink, bool removeAssociatedSharingLinkGroup);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<string> CreateOrganizationSharingLink(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string url, bool isEditLink);

[Microsoft.SharePoint.Client.RemoteAttribute]
void DestroyOrganizationSharingLink(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string url, bool isEditLink, bool removeAssociatedSharingLinkGroup);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<global::Microsoft.SharePoint.Client.SharingLinkKind> GetSharingLinkKind(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string fileUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<global::Microsoft.SharePoint.Client.SharingLinkData> GetSharingLinkData(string linkUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<string> MapToIcon(string fileName, string progId, global::Microsoft.SharePoint.Client.Utilities.IconSize size);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<string> GetWebUrlFromPageUrl(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string pageFullUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ListCollection GetLists(global::Microsoft.SharePoint.Client.GetListsParameters getListsParams);

Expand All @@ -533,6 +554,9 @@ public partial interface IWeb
[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.List GetList(string strUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.List GetListByTitle(string title);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.List GetListUsingPath(global::Microsoft.SharePoint.Client.ResourcePath path);

Expand Down Expand Up @@ -561,64 +585,79 @@ public partial interface IWeb
global::Microsoft.SharePoint.Client.ClientResult<global::System.IO.Stream> GetSPAppContextAsStream();

[Microsoft.SharePoint.Client.RemoteAttribute]
void Update();
global::Microsoft.SharePoint.Client.List DefaultDocumentLibrary();

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.View GetViewFromUrl(string listUrl);
global::Microsoft.SharePoint.Client.File GetFileById(global::System.Guid uniqueId);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.View GetViewFromPath(global::Microsoft.SharePoint.Client.ResourcePath listPath);
global::Microsoft.SharePoint.Client.Folder GetFolderById(global::System.Guid uniqueId);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByServerRelativeUrl(string serverRelativeUrl);
global::Microsoft.SharePoint.Client.File GetFileByLinkingUrl(string linkingUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByServerRelativePath(global::Microsoft.SharePoint.Client.ResourcePath serverRelativePath);
global::Microsoft.SharePoint.Client.File GetFileByGuestUrl(string guestUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::System.Collections.Generic.IList<global::Microsoft.SharePoint.Client.DocumentLibraryInformation> GetDocumentLibraries(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string webFullUrl);
global::Microsoft.SharePoint.Client.File GetFileByGuestUrlEnsureAccess(string guestUrl, bool ensureAccess);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::System.Collections.Generic.IList<global::Microsoft.SharePoint.Client.DocumentLibraryInformation> GetDocumentAndMediaLibraries(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string webFullUrl, bool includePageLibraries);
global::Microsoft.SharePoint.Client.File GetFileByWOPIFrameUrl(string wopiFrameUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<global::Microsoft.SharePoint.Client.DocumentLibraryInformation> DefaultDocumentLibraryUrl(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string webUrl);
global::Microsoft.SharePoint.Client.File GetFileByStreamFrameUrl(string streamFrameUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.List DefaultDocumentLibrary();
global::Microsoft.SharePoint.Client.File GetFileByUrl(string fileUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileById(global::System.Guid uniqueId);
global::Microsoft.SharePoint.Client.Folder GetFolderByServerRelativeUrl(string serverRelativeUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.Folder GetFolderById(global::System.Guid uniqueId);
global::Microsoft.SharePoint.Client.Folder GetFolderByServerRelativePath(global::Microsoft.SharePoint.Client.ResourcePath serverRelativePath);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByLinkingUrl(string linkingUrl);
global::Microsoft.SharePoint.Client.ClientResult<string> CreateSitePage(string pageMetaData);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByGuestUrl(string guestUrl);
global::Microsoft.SharePoint.Client.ClientResult<string> GetSitePageCopyToStatus(global::System.Guid workItemId);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByGuestUrlEnsureAccess(string guestUrl, bool ensureAccess);
global::Microsoft.SharePoint.Client.ClientResult<string> GetSitePageMoveStatus(global::System.Guid workItemId);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByWOPIFrameUrl(string wopiFrameUrl);
void ApplyWebTemplate(string webTemplate);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByUrl(string fileUrl);
void DeleteObject();

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.Folder GetFolderByServerRelativeUrl(string serverRelativeUrl);
void Recycle();

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.Folder GetFolderByServerRelativePath(global::Microsoft.SharePoint.Client.ResourcePath serverRelativePath);
void Update();

[Microsoft.SharePoint.Client.RemoteAttribute]
void ApplyWebTemplate(string webTemplate);
global::Microsoft.SharePoint.Client.View GetViewFromUrl(string listUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
void DeleteObject();
global::Microsoft.SharePoint.Client.View GetViewFromPath(global::Microsoft.SharePoint.Client.ResourcePath listPath);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByServerRelativeUrl(string serverRelativeUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.File GetFileByServerRelativePath(global::Microsoft.SharePoint.Client.ResourcePath serverRelativePath);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::System.Collections.Generic.IList<global::Microsoft.SharePoint.Client.DocumentLibraryInformation> GetDocumentLibraries(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string webFullUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::System.Collections.Generic.IList<global::Microsoft.SharePoint.Client.DocumentLibraryInformation> GetDocumentAndMediaLibraries(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string webFullUrl, bool includePageLibraries);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<global::Microsoft.SharePoint.Client.DocumentLibraryInformation> DefaultDocumentLibraryUrl(global::ProxyInterfaceSourceGeneratorTests.Source.PnP.IClientRuntimeContext context, string webUrl);

[Microsoft.SharePoint.Client.RemoteAttribute]
global::Microsoft.SharePoint.Client.ClientResult<global::System.IO.Stream> PageContextInfo(bool includeODBSettings, bool emitNavigationInfo);
Expand Down
2 changes: 1 addition & 1 deletion tests/ProxyInterfaceSourceGeneratorTests/InheritedInterfaceTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using AwesomeAssertions;
using CSharp.SourceGenerators.Extensions;
using CSharp.SourceGenerators.Extensions.Models;
using FluentAssertions;
using Microsoft.CodeAnalysis.CSharp.Syntax;
using ProxyInterfaceSourceGenerator;
using ProxyInterfaceSourceGeneratorTests.Helpers;
Expand Down
2 changes: 1 addition & 1 deletion tests/ProxyInterfaceSourceGeneratorTests/PnPTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
using AwesomeAssertions;
using CSharp.SourceGenerators.Extensions;
using CSharp.SourceGenerators.Extensions.Models;
using FluentAssertions;
using ProxyInterfaceSourceGenerator;
using ProxyInterfaceSourceGeneratorTests.Helpers;

Expand Down
Loading