Skip to content

fix: prevent unhandled rejection when ref.current becomes null between async iterations #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jhotadhari wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: prevent unhandled rejection when ref.current becomes null between async iterations #203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/AdaptivePopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,6 +236,11 @@ export default class AdaptivePopover extends Component<AdaptivePopoverProps, Ada
let rect: Rect;
count = 0;
do {
// Guard against ref becoming null between async iterations
if (!fromRef?.current) {
this.debug('calculateRectFromRef - ref not set, bailing');
return;
}
rect = await getRectForRef(fromRef);
if ([rect.x, rect.y, rect.width, rect.height].every(i => i === undefined)) {
this.debug('calculateRectFromRef - rect not found, all properties undefined');
Expand Down
2 changes: 1 addition & 1 deletion src/Utility.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export function getRectForRef(ref: RefType): Promise<Rect> {
resolve(new Rect(x, y, width, height))
);
} else {
reject(new Error('getRectForRef - current is not set'));
resolve(new Rect(0, 0, 0, 0));
}
});
}
Expand Down