perf(settings): memoize derived policy templates to trim render work#1199
Merged
kryputh merged 6 commits intoJun 29, 2026
Merged
Conversation
4d6dd34 to
c1e18fe
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
currentDraft,liveTemplate,selectedPreview,selectedPreferences,previewMatchesCurrent, andapplyingWillReplaceCurrent) insideuseMemohooks inside theInboxSettingscomponent.currentDraftobject, ensuring referential equality is preserved across re-renders when nothing changes.handleTemplateChange,handleApply,handleSaveCustom,updateUnknownSenders, andupdateMinimumPostage) withuseCallbackto prevent inline function recreation.Why it was done
Prior to this change, the
InboxSettingsrecalculations and object instantiations were triggered on every render cycle. Because theminimumPostageis controlled by a continuous input field, every single keystroke was forcing React to re-compute the comparison logic against the built-inMAILBOX_POLICY_TEMPLATESarray and re-instantiate local closures. Memoizing these expensive dependency chains significantly reduces unnecessary reconciliation latency and provides a snappier feeling while tweaking postage values.How it was verified
src/components/mail/SettingsModal.tsx.tsc --noEmitlocally (the only errors are pre-existing type errors outside the modified scope) to ensure proper React hook dependencies were included.closes #938