fix(tools): prevent import time crashes, correct result handling, and improve input validation

[Div1912]

What changed

Before:
Environment variables were read at module load time using const STELLAR_PUBLIC_KEY = process.env.STELLAR_PUBLIC_KEY!. This caused the entire module to crash on import in serverless/edge environments where env vars are not yet injected at parse time. The ! non-null assertion also suppressed TypeScript's safety check while a manual runtime guard was still needed, making the code contradictory.

deposit and swap used result ?? "success message" which meant the success string was only returned when the result was falsy — silently discarding actual transaction results on success.

buyA === undefined in the swap validation missed null, allowing invalid calls to pass through.

func was typed as any, defeating the Zod schema that was already defined on the tool.

contractAddress was always spread into config even when undefined, polluting the config object passed to contract functions.

---

After:
Environment variables are now read inside lazy getter functions (getStellarPublicKey, getStellarNetwork, getSorobanRpcUrl) that are called at invocation time, not import time. This makes the module safe to import in any environment.

deposit and swap now use a ternary to correctly return transaction results on success and a fallback message only when the result is empty.

buyA == null now correctly catches both undefined and null.

func is now typed as z.infer<typeof schema> for full type safety aligned with the Zod schema.

contractAddress is conditionally spread into config only when it has a value.

---

Why it was necessary:
The module-level env var crash was a production risk in any serverless deployment. The inverted result logic on deposit and swap meant successful transactions were returning no meaningful output to the agent, breaking observability. The remaining fixes close type safety gaps that could cause subtle runtime failures as the codebase scales.

---

Summary by cubic

Refactors env var handling to use lazy getters to avoid import-time crashes, fixes tool result handling and input typing, and makes transaction builders network-aware with safer defaults.

• Refactors

  • Use lazy getters for STELLAR_PUBLIC_KEY, STELLAR_NETWORK, and SOROBAN_RPC_URL; centralize the Zod schema and type func with z.infer<typeof schema>; only include contractAddress when provided.
  • Make transaction builders network-aware and safer: require networkPassphrase (no hardcoded testnet), use ?? for fee defaults, guard memo for FeeBumpTransaction, add args-length check, narrow buildTransactionFromXDR config to { memo }, and throw on unhandled operation types.

• Bug Fixes

  • Return actual results from deposit and swap (JSON stringified); show a simple fallback only when empty.
  • Validate buyA with == null to catch both undefined and null.

^{Written for commit 6f74633. Summary will update on new commits.}

[cubic-dev-ai]

2 issues found across 1 file

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="tools/contract.ts">

<violation number="1" location="tools/contract.ts:23">
P2: `getSorobanRpcUrl` uses `??`, so an empty `SOROBAN_RPC_URL` is treated as valid and passed as `rpcUrl`, causing runtime connection failures instead of falling back to default.</violation>

<violation number="2" location="tools/contract.ts:81">
P2: Truthiness-based handling for deposit/swap misreports successful executions as no-value results because these helpers normally return undefined.</violation>
</file>

_{Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.}

[daiwikmh]

ci checks fail