Add named NPCs with backstories and dialogue system by Copilot · Pull Request #45 · Stephenson-Software/FishE

Copilot · 2026-02-01T13:13:42Z

Expand NPC Backgrounds - Implementation Complete ✅

Summary

Successfully implemented a comprehensive NPC system for the FishE fishing village game. Each location now has a unique named NPC with a detailed backstory that players can discover through dialogue.

NPCs Added:

Sam the Dock Worker (Docks) - Multi-generational fishing family
Gilbert the Shopkeeper (Shop) - 30-year veteran with family legacy
Old Tom the Barkeep (Tavern) - Former sailor with colorful past
Margaret the Teller (Bank) - Dedicated banker focused on helping villagers

Recent Changes (addressing PR feedback):

✅ Fixed Stats import in bank.py (was using pstats.Stats instead of stats.stats.Stats)
✅ Extracted duplicate talkToNPC() logic into UserInterface.showDialogue() method
✅ Improved test coverage - all talkToNPC tests now actually call the method
✅ Added test for new showDialogue() method
✅ All 89 unit tests passing

Implementation Details:

✅ Created NPC class with name and backstory attributes
✅ Added "Talk to [NPC Name]" menu option to all 4 locations
✅ Implemented dialogue system displaying rich backstories
✅ Code review completed, all feedback addressed
✅ Security scan passed (0 vulnerabilities)
✅ Backward compatible with existing saves
✅ DRY principle applied - no code duplication

Original prompt

This section details on the original issue you should resolve

<issue_title>Expand NPC backgrounds</issue_title>
<issue_description>Each NPC currently in the world should be given a name and a backstory and it should be possible for the player to talk to them to learn more about them.</issue_description>

Comments on the Issue (you are @copilot in this section)

Fixes Expand NPC backgrounds #44

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot

Pull request overview

Adds an interactable NPC system so players can talk to named characters in each location and read their backstories.

Changes:

Introduced a new NPC model with name, backstory, and introduce().
Integrated a location-specific NPC plus a “Talk to …” menu option in Bank/Docks/Shop/Tavern.
Added/updated tests to validate NPC initialization and updated location menus.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
tests/npc/test_npc.py	Adds unit tests for the new `NPC` class initialization and `introduce()` formatting.
tests/location/test_tavern.py	Updates Tavern tests for the new NPC field and shifted menu options; adds “talk” action test.
tests/location/test_shop.py	Updates Shop tests for the new NPC field and shifted menu options; adds “talk” action test.
tests/location/test_docks.py	Updates Docks tests for the new NPC field and shifted menu options; adds “talk” action test.
tests/location/test_bank.py	Updates Bank tests for the new NPC field and shifted menu options; adds “talk” action test.
src/npc/npc.py	Adds the `NPC` class and `introduce()` method.
src/npc/init.py	Initializes the new `npc` package.
src/location/tavern.py	Instantiates Tavern NPC and adds dialogue option + handler.
src/location/shop.py	Instantiates Shop NPC and adds dialogue option + handler.
src/location/docks.py	Instantiates Docks NPC and adds dialogue option + handler.
src/location/bank.py	Instantiates Bank NPC and adds dialogue option + handler.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-01T22:18:22Z

tests/location/test_tavern.py

+def test_talkToNPC():
+    # prepare
+    tavernInstance = createTavern()
+
+    # check


This test doesn’t call Tavern.talkToNPC(), so it won’t catch regressions in the dialogue display/pause logic. You can follow the pattern used elsewhere in this file (mock builtins.input, userInterface.lotsOfSpace/divider, and capture output) to execute talkToNPC() without blocking and assert it prints the introduction and updates currentPrompt.text.

Fixed in bbf82ef - test now calls talkToNPC() with mocked showDialogue and verifies the introduction text is passed correctly.

Copilot · 2026-02-01T22:18:22Z

tests/location/test_docks.py

+def test_talkToNPC():
+    # prepare
+    docksInstance = createDocks()
+
+    # check


test_talkToNPC currently only checks the NPC data and doesn’t execute Docks.talkToNPC(). Since the suite already mocks builtins.input/stdout for other interactive methods, consider calling talkToNPC() with builtins.input mocked (and capturing stdout) to verify it prints the introduction and resets currentPrompt.text.

Fixed in bbf82ef - test now executes talkToNPC() with mocked showDialogue and asserts the introduction is passed correctly.

Copilot · 2026-02-01T22:18:22Z

tests/location/test_bank.py

+def test_talkToNPC():
+    # prepare
+    bankInstance = createBank()
+
+    # check


test_talkToNPC doesn’t run Bank.talkToNPC()—it only verifies the NPC data. Consider mocking builtins.input (so it won’t block), stubbing userInterface.lotsOfSpace/divider, and asserting the introduction is printed (e.g., with capsys) and currentPrompt.text is reset.

Fixed in bbf82ef - test now runs talkToNPC() with mocked showDialogue and verifies the introduction text and method call.

Copilot · 2026-02-01T22:18:23Z

src/location/bank.py

 from prompt.prompt import Prompt
 from world.timeService import TimeService
 from ui.userInterface import UserInterface
+from npc.npc import NPC


In this file the Stats type hint is coming from pstats (line 1), which is a different class than the game’s stats.stats.Stats used elsewhere (e.g., src/location/shop.py:6). Since this PR touches the import block, please switch the Stats import here to from stats.stats import Stats for consistency and correct typing.

Fixed in bbf82ef - changed import from pstats.Stats to stats.stats.Stats for correct typing.

Copilot · 2026-02-01T22:18:23Z

src/location/tavern.py

+    def talkToNPC(self):
+        self.userInterface.lotsOfSpace()
+        self.userInterface.divider()
+        print(self.npc.introduce())
+        self.userInterface.divider()


talkToNPC() is identical across multiple locations (Bank/Docks/Shop/Tavern). Consider extracting this into a shared helper (e.g., a UserInterface.showDialogue(text) method or a small utility function) to avoid keeping four copies in sync if the dialogue UI changes.

Fixed in bbf82ef - extracted talkToNPC() into UserInterface.showDialogue() method to eliminate duplication across all four locations.

Copilot · 2026-02-01T22:18:23Z

tests/location/test_shop.py

+    # call
+    # We can't fully test the input() part, but we can test the method exists
+    # and the NPC has the right data
+    assert shopInstance.npc.name == "Gilbert the Shopkeeper"
+    assert len(shopInstance.npc.backstory) > 0


This test doesn’t exercise Shop.talkToNPC()—it only asserts the NPC data. Since other tests in this suite already patch builtins.input, you can unit-test the method by mocking builtins.input to return immediately and asserting the printed introduction (e.g., via capsys) and prompt update.

Fixed in bbf82ef - test now exercises talkToNPC() with mocked showDialogue and asserts the introduction text is passed correctly.

dmccoystephenson · 2026-02-01T22:42:52Z

@copilot address comments

…ace, improve tests Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Initial plan

3e45276

Copilot AI assigned Copilot and dmccoystephenson Feb 1, 2026

Copilot started work on behalf of dmccoystephenson February 1, 2026 13:13 View session

Copilot AI and others added 2 commits February 1, 2026 13:18

Add NPC system with names and backstories for all locations

8d9fd63

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Fix trailing whitespace in test files

d0ce3a0

Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add names and backstories to NPCs~~ Add named NPCs with backstories and dialogue system Feb 1, 2026

Copilot AI requested a review from dmccoystephenson February 1, 2026 13:27

Copilot finished work on behalf of dmccoystephenson February 1, 2026 13:27

dmccoystephenson requested a review from Copilot February 1, 2026 22:14

Copilot started reviewing on behalf of dmccoystephenson February 1, 2026 22:14 View session

Copilot AI reviewed Feb 1, 2026

View reviewed changes

Copilot started work on behalf of dmccoystephenson February 1, 2026 22:43 View session

Address PR comments: fix Stats import, extract dialogue to UserInterf…

bbf82ef

…ace, improve tests Co-authored-by: dmccoystephenson <21204351+dmccoystephenson@users.noreply.github.com>

Copilot finished work on behalf of dmccoystephenson February 1, 2026 22:47

dmccoystephenson marked this pull request as ready for review February 1, 2026 22:52

dmccoystephenson approved these changes Feb 1, 2026

View reviewed changes

dmccoystephenson merged commit e4774d1 into main Feb 1, 2026
1 check passed

dmccoystephenson deleted the copilot/expand-npc-backgrounds branch February 1, 2026 22:52

Conversation

Copilot AI commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Expand NPC Backgrounds - Implementation Complete ✅

Summary

NPCs Added:

Recent Changes (addressing PR feedback):

Implementation Details:

Comments on the Issue (you are @copilot in this section)

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

dmccoystephenson commented Feb 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Copilot AI commented Feb 1, 2026 •

edited

Loading