Solve circular dependency between zernike.py and interferometer_zenike.py#16
Open
fHachenberg wants to merge 2 commits intoSterncat:masterfrom
Open
Solve circular dependency between zernike.py and interferometer_zenike.py#16fHachenberg wants to merge 2 commits intoSterncat:masterfrom
fHachenberg wants to merge 2 commits intoSterncat:masterfrom
Conversation
…nd zernike.py by moving __zernike_cartiesian__ and __zernike_polar__ into separate module. Did the same thing for respective routines in zernike_rec.py (for symmetry with zernike.py)
Owner
|
I got your point. Did you try every import and zernike wavefront generate(or interferograms) functions after this change? Everything worked well? Busy outside, so didn't test by myself yet. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved zernike_cartesian and zernike_polar into separate module for zernike.py and zernike_rec.py respectively (for symmetry)