Fixing babel transpiler errors. windows environments need to normaliz…#16
Open
nenitiko wants to merge 1 commit intoSteveSanderson:masterfrom
Open
Fixing babel transpiler errors. windows environments need to normaliz…#16nenitiko wants to merge 1 commit intoSteveSanderson:masterfrom
nenitiko wants to merge 1 commit intoSteveSanderson:masterfrom
Conversation
…e directory separators otherwise babel transformation wont skip files specified in configuration
neelabhg
added a commit
to neelabhg/sysbuild
that referenced
this pull request
Nov 22, 2015
1. Added babel-core as a dev-dependency. 2. Fixed path separator differences which were causing Babel to transpile skipped files under Windows. The fix was taken from SteveSanderson/generator-ko#16.
|
👍 This is ace, I spent half an hour tinkering and making it work then noticed this PR - you could have saved me half an hour had I looked before tinkering haha. |
|
Good job in Fixing the issue! 👍 |
|
thks, just fixed the bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried running the generator in windows and got two different errors:
I added both the babel-core npm depepdency and the normalization/conversion of backslashes to posix dir separators (by using github.com/sindresorhus/slash) before transpilation occurs.