Recover stale storefront tabs after deployments - #62
Merged
Conversation
SteveSimonson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Returning to an open iBamboo tab had exposed a pre-deploy layout and legacy fixed-size content balloons. The HTML shell already revalidates, but a bfcache snapshot can skip that request. This guard checks the current shell on future persisted restores and refreshes only after a deployment changed the storefront assets.
A tab that was already running an older bundle still needs one normal reload to receive this recovery code; the affected tab was cleanly reloaded during verification.
Validation
npm run lintnpm test(17 passing)npm run build