Move MT Results panel from Actions to Results task#38
Conversation
Co-authored-by: bHimes <3077528+bHimes@users.noreply.github.com>
bHimes
left a comment
There was a problem hiding this comment.
This didn't quite work.
I think the problem is related to the differences when the spa vs template matching workflow is selected.
If you look at the actions panel for example, there are two different panels for the two workflows.
- actions_panel_spa
- actions_panel_tm
One solution might be that we need to get rid of the existing results_panel and replace it with results_panel_spa and results_panel_tm, where only the latter has the MT Results.
It may alternatively be possible to avoid greating a fully seperate panel and instead, make sure that on switching between SPA and TM workflows, the page for the MT results is added (switching to TM) or removed (switching to SPA)
If the latter is possible, lets try that first.
Co-authored-by: bHimes <3077528+bHimes@users.noreply.github.com>
Co-authored-by: bHimes <3077528+bHimes@users.noreply.github.com>
I've implemented the second solution you suggested - dynamically adding/removing the MT Results panel when switching workflows. Changes include:
The latest commit (be64916) should allow the MT Results panel to appear only when the Template Matching workflow is active, maintaining UI consistency. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
bHimes
left a comment
There was a problem hiding this comment.
Okay, that got closer, the GUI was able to open, but there were several new problems. Rather than trouble shoot those individually, lets fall back to the first suggested solution from the last review.
That is, lets follow the pattern we had for the actions panel at the start of this issue. So actions_panel_spa and actions_panel_tm.
Let's extend that pattern for the results panel, i.e. creating a results_panel_tm and results_panel_spa. When making the changes for the results pannel, we will follow all the patterns and methods used to handle workflow switches that are in place for the actions panel.
Co-authored-by: bHimes <3077528+bHimes@users.noreply.github.com>
I've implemented the first suggested solution, creating separate results panels for the different workflows. The implementation follows the same pattern used for the actions panels:
These changes (a51198d) ensure that the MT Results panel appears only in the Template Matching workflow without having to dynamically add or remove pages. Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Changes Made
This PR moves the "MT Results" panel from the Actions task to the Results task in the cisTEM Template Matching (TM) workflow. This change helps maintain a consistent organization of panels within the cisTEM GUI, where results should be grouped under the Results task rather than the Actions task.
Specific Changes:
match_template_results_panelto useresults_panel->ResultsBookas its parent (instead ofactions_panel_tm->ActionsBook)match_template_results_panelfromactions_panel_tm->ActionsBook->AddPagematch_template_results_paneltoresults_panel->ResultsBook->AddPagematch_template_results_panelinActionsPanelTm.cppmatch_template_results_panelinMyResultsPanel.cppThese changes ensure that users will now find the Template Matching results under the Results category in the left panel, maintaining a more intuitive and consistent user interface organization.
Fixes #37.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.