Skip to content

Fix multiprocessing ValueProxy AttributeError in AutoAlign widget #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: ctf3d_work
Choose a base branch
from
Open

Fix multiprocessing ValueProxy AttributeError in AutoAlign widget #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
044f59a
Initial plan
Copilot Sep 3, 2025
2905629
Fix multiprocessing lock issue preventing queued actions from running
Copilot Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions python/gui/autoalign_widget.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ def align_single_asset(asset_data: Dict[str, Any], output_queue, progress_value,
status_queue.put(f"Starting alignment for {asset_name}")

# Update progress
with progress_value.get_lock():
progress_value.value = 10
progress_value.value = 10

# Build emClarity command
cmd = [
Expand Down Expand Up @@ -76,19 +75,16 @@ def align_single_asset(asset_data: Dict[str, Any], output_queue, progress_value,
if "Progress:" in line:
try:
prog = int(line.split("Progress:")[1].split("%")[0].strip())
with progress_value.get_lock():
progress_value.value = max(10, min(90, prog))
progress_value.value = max(10, min(90, prog))
except:
pass
elif "Completed" in line:
with progress_value.get_lock():
progress_value.value = 90
progress_value.value = 90

return_code = process.wait()

if return_code == 0:
with progress_value.get_lock():
progress_value.value = 100
progress_value.value = 100
output_queue.put({'asset': asset_name, 'success': True, 'message': 'Completed successfully'})
status_queue.put(f"Completed alignment for {asset_name}")
else:
Expand Down Expand Up @@ -178,8 +174,7 @@ def run(self):
while completed_assets + failed_assets < total_assets and not self.should_stop:
# Update individual asset progress
for asset_name, progress_val in progress_values.items():
with progress_val.get_lock():
current_progress = progress_val.value
current_progress = progress_val.value
self.asset_progress_updated.emit(asset_name, current_progress)

# Calculate overall progress
Expand Down