feat: schedules admin page + per-schedule timeout (#986 slice C) - #998
Merged
Conversation
Slice C closes the scheduled-jobs epic (#986). New Admin-only /admin/schedules page (nav: after Appearance, ti-clock): create a schedule (containerized specs only — the select never offers an External; cron validated server-side via croner; one argv line per row → cmd_json; timeout in minutes with an anti-overflow cap), enable/disable toggle, delete behind the confirm dialog, the computed NEXT occurrence per schedule, and the last-20 run history with status badges and the log tail in a <details>. 32 i18n keys ×4. Per-schedule timeout wired end to end: SpawnRequest.job_timeout_secs (builder, consumed only by run_job — default stays the 1 h cap) ← schedules.timeout_secs (the column slice B shipped). db: recent_runs join for the history. Docs: admin.md § Schedules (semantics: no fire-on-create, downtime collapses, leader-only in HA, job-failed webhook). Route tests: create/validate/toggle/delete + Editor gets 403. Closes #986 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #986 (slice C of 3 — closes the epic; A = #996, B = #997)
What
/admin/schedules(Admin-only; nav after Appearance): create form (containerized specs only — External never offered; cron validated server-side via croner; argv one-per-line →cmd_json; timeout in minutes, capped against overflow), schedule table with the computed next occurrence, enable/disable toggle, delete behinddata-confirm, and the last-20 run history (status badges, exit code, duration, log tail in<details>).SpawnRequest.job_timeout_secs(consumed only byrun_job; default stays the 1 h cap) wired from thetimeout_secscolumn slice B shipped.db::schedules::recent_runs(join for spec ids, both dialects, tested on sqlite + real pg).admin.md§ Schedules (ETL semantics, leader-only,job-failedwebhook); 32 i18n keys ×4 locales.Verification
-D warningsclean, i18n parity.RequireAdmin, confirm on delete, admin-only section fall-through) re-verified by hand.🤖 Generated with Claude Code