-
Notifications
You must be signed in to change notification settings - Fork 41
Hide non-numeric fields for Math calculations #2619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shervElmi
wants to merge
13
commits into
master
Choose a base branch
from
hide-non-numeric-fields-math-calc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3d6462c
Add helper method for non-numeric field types and fix trailing whites…
shervElmi 9838cfc
Exclude non-numeric field types from Math calculation field dropdowns
shervElmi 46d7a76
Add event listener to refresh calc field list when field type changes
shervElmi d01d881
Refactor calculation type check and remove unused event listener
shervElmi 64442a1
Add empty state message for Math calculations with no numeric fields
shervElmi b4e38b4
Simplify Math calculation type check in getExcludeArray function
shervElmi 4e9263f
Optimize calculation type check by caching isMathCalcType result
shervElmi 8f9ad9a
Add top padding to empty state message for Math calculations with no …
shervElmi 385fa4f
Merge remote-tracking branch 'origin/HEAD' into hide-non-numeric-fiel…
shervElmi bdffb03
Add auto generated files
shervElmi df83b87
Move non_numeric_field_types method to FrmProAppHelper class
shervElmi a07c9b2
Refactor calculation field filtering to use allowlist instead of excl…
shervElmi ebd0345
Add formidable_admin.js file
shervElmi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.