release: v0.13.1 — suppress discovery cache warning - #11
Merged
Conversation
Pass cache_discovery=False to googleapiclient.discovery.build() so the warning "file_cache is only supported with oauth2client<4.0.0" stops appearing in dock logs on every YouTube API call. The file cache is incompatible with google-auth (used via google-auth-oauthlib); discovery docs are still cached in-memory per process — all the dock's short-lived hook subprocesses ever needed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
mypy 2.1+ on CI flagged Credentials.refresh() and Credentials.from_authorized_user_file() as no-untyped-call errors because google-auth doesn't ship inline type hints. Existing type: ignore on line 70 worked on old mypy but became unused on newer versions in some envs. Switch to a per-module override (disallow_untyped_calls = false for reeln_google_plugin.auth) so the suppression is independent of mypy version and the existing type: ignore can be removed. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cache_discovery=Falsewhen building the YouTube service inbuild_youtube_service()so the noisyfile_cache is only supported with oauth2client<4.0.0warning stops appearing in dock logs.__init__.py,plugin.py, CHANGELOG).Why
The dock invokes plugin hooks via short-lived
reeln hooks runsubprocesses. Each invocation prints a warning that the file_cache extra is incompatible withgoogle-auth. The file cache wouldn't help anyway — subprocesses are throwaway and can't share cached discovery docs.cache_discovery=Falseis Google's documented escape hatch and keeps the in-memory cache (the only cache that matters per-process).Test plan
uv run pytest -q— 285 tests passtest_builds_serviceupdated to assert the new kwarg🤖 Generated with Claude Code