Conversation
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
Hey Jakub, and thanks! Just got back from KubeCon with a hefty backlog 😅 Reviewing this is on my TODO list! |
|
No worries, it is not urgent. The current code works with Kafka 4.0. I just wanted to keep it a bit up to date. |
anderseknert
left a comment
There was a problem hiding this comment.
Very nice! Just some questions but nothing blocking.
| - "--set=bundles.authz.resource=bundle.tar.gz" | ||
| depends_on: | ||
| - nginx | ||
| zookeeper: |
README.md
Outdated
| @@ -8,7 +8,7 @@ Open Policy Agent (OPA) plugin for Kafka authorization. | |||
| ### Prerequisites | |||
|
|
|||
| * Kafka 2.7.0+ | |||
There was a problem hiding this comment.
Is this still true? i.e. you can still drop this jar into a Kafka that old?
There was a problem hiding this comment.
Good point. The code itself is not really changed much. But the changes around Jackson dependencies make it compatible with Kafka 3.8 and newer (because of the Jackson versions it uses). I guess that should be fine as there are no real new feature here and users of older Kafka versions can use the previous release of the OPA Authorizer?
Signed-off-by: Jakub Scholz <www@scholzj.com>
|
Changes LGTM, feel free to merge whenever you want. |
Kafka has recently had a new major release 4.0. This PR updates the OPA Authorizer to use Kafka 4.0 as well: