Exotic Audio Handling #68
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fastforward
Contributor
Author
|
#57 Is covered in this PR |
Changes to how exotic audio is handled. Focused on True HD and Opus for right now (need samples of other formats), this changes the default behavior for Open, Import, and Add to Queue. With a new Preference to allow disabling of exotic multi-channel tracks by default, those tracks will be deselected by default. If that option is not used, the tracks will now default to AAC + AC3, for more consistent handling. Stereo or Mono tracks are handled as just stereo tracks, no matter what. This also addresses the scenario where an MP4 container has an AAC 6ch track, with no 2ch fallback. Subler wouldn't give you control over how this is handled when using Open or Add to Queue. This is now consistent across all paths. Changes 6ch AAC default to AC3 conversion, per GH issue.
Contributor
Author
|
@galad87 have you had a chance to look at this one? |
Contributor
|
I think I took a quick look at this a month ago, then forgot to write down my thoughts. I'll check next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to how exotic audio is handled. Focused on True HD and Opus for right now (need samples of other formats), this changes the default behavior for Open, Import, and Add to Queue.
With a new Preference to allow disabling of exotic multi-channel tracks by default, those tracks will be deselected by default. If that option is not used, the tracks will now default to AAC + AC3, for more consistent handling. Stereo or Mono tracks are handled as just stereo tracks, no matter what.
This also addresses the scenario where an MP4 container has an AAC 6ch track, with no 2ch fallback. Subler wouldn't give you control over how this is handled when using Open or Add to Queue. This is now consistent across all paths.
Changes 6ch AAC default to AC3 conversion, per GH issue.