Skip to content

Dev #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
remytuyeras merged 2 commits into from
Feb 4, 2026
Merged

Dev #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
02297d1
clarify comment
remytuyeras Feb 4, 2026
2b6f47f
clarify comment
remytuyeras Feb 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions summoner/logger.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ def configure_logger(logger: logging.Logger, logger_cfg: dict[str, Any]) -> None
- backup_count (int)
- log_keys (list[str] or None)
"""
# 0) Remove the handlers managed in the core SDK (else use handler._keep = True)
# 0) Remove handlers managed in the core SDK (else use handler._keep = True)
for handler in list(logger.handlers):
if getattr(handler, "_keep", False):
continue
Expand All @@ -182,7 +182,6 @@ def configure_logger(logger: logging.Logger, logger_cfg: dict[str, Any]) -> None
logger.setLevel(log_level)

# 2) Attach console/file handlers according to config.
# Do NOT gate this on "logger.handlers" because external handlers

# console
if logger_cfg.get("enable_console_log", True):
Expand Down