fix: emit JPEG frames for default video streams - #1
Closed
SunsetWan wants to merge 1 commit into
Closed
Conversation
Signed-off-by: wanchenxi <wanchenxi@hikvision.com.cn>
Owner
Author
|
Superseded by lycorp-jp#94. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scale=1.0/quality=80settingsUnreleasedRoot cause
Both the iOS screenshot API and Android
screencap -pproduce PNG data. The shared frame processor treated the default scale and quality as an unconditional passthrough fast path, while both MJPEG writers labeled every frame asimage/jpeg. This produced PNG payloads with a JPEG MIME type.The fast path now checks the source container with ImageIO and only passes through actual JPEG input. PNG captures are re-encoded as JPEG. The shared
rawandffmpegscreenshot-backed formats now also consistently emit the JPEG frames their command descriptions promise.User impact
Strict MJPEG clients no longer receive PNG frames mislabeled as JPEG at default settings. Non-default quality and scale behavior is unchanged.
Validation
swift test --filter VideoFrameProcessingTests: 9 passedmake build: passedmake test: all 306 tests passed, then the Swift test process aborted during teardown withfreed pointer was not the last allocation; the same post-test abort reproduces on unchangedorigin/mainadbon PATH