Fixes to AACGM_v2 conversions and rpos geolocation#661
Open
egthomas wants to merge 3 commits into
Open
Conversation
…ight for multi-hop scatter with Chisham VHM using actual elevation angle, instead of artificially high pseudo virtual height
…e already in geocentric instead of geodetic
…r multi-hop scatter with Chisham VHM, and updating C version to use rrad instead of RE for consistency
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses #660 and #548 by making several changes throughout the RST. First, the calls to
AACGM_v2_Convertnow use theGEOCENTRICoption where the input coordinates are already in geocentric (rather than geodetic) coordinates, thus avoiding an extra conversion into geocentric coordinates. There isn't an obvious way to test this other than to insert your own debug print statements into the modified plotting binaries orinvmag.c, or just runningmake_gridto ensure it still gives nearly identical results.Second, an older bug causing AACGM_v2 warnings when applying the Chisham virtual height model to very long-range (presumably multi-hop) scatter has been fixed by modifying
fldpnthto return the "corrected" virtual height for multi-hop ionospheric scatter rather than the artificially-high "pseudo" virtual height needed for the Chisham VHM's range-finding. This particular fix is most easily tested by usingmake_gridwith the-chishamkeyword on recent Falkland Islands (FIR) data.Note there is another error in
cnvtcoord.cwhere input elevation angles are not correctly handled byfldpnth, but that may be better left for another pull request (or perhaps those functions should be replaced entirely by the more comprehensiveRPosGeo_v2functionality I added a few years ago).