Skip to content

ci: add GitHub Actions CI workflow #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
SuperInstance wants to merge 1 commit into from
Closed

ci: add GitHub Actions CI workflow #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,12 @@
name: CI
on:
push:
branches: [main]
pull_request:
branches: [main]
on: [push, pull_request]
jobs:
build:
test:
runs-on: ubuntu-latest
strategy:
matrix:
python-version: ["3.10", "3.11", "3.12"]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-python@v5
with:
python-version: ${{ matrix.python-version }}
- run: pip install pyyaml
- run: python3 -c "import ast; [ast.parse(open(f).read()) for f in __import__('pathlib').Path('.').rglob('*.py') if '.git' not in str(f)]" || true
- run: pip install pytest && python -m pytest tests/ -v --timeout=60 2>/dev/null || echo "No tests — syntax check passed"
python-version: "3.12"
- run: pip install pytest
Copy link
Copy Markdown

@beta-devin-ai-integration beta-devin-ai-integration Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 CI installs only pytest but not the project's own dependencies

The workflow runs pip install pytest but never installs the project itself or its dependencies (e.g., pip install . or pip install -e .). Since the test file (test_conformance.py) imports conformance_core, and the project defines its build system in pyproject.toml, the tests may fail to import project modules unless they happen to work as raw scripts from the repo root. This is fragile and inconsistent with the project's pyproject.toml setup.

Suggested change
- run: pip install pytest
- run: pip install -e .
Staging: Open in Devin

Was this helpful? React with 👍 or 👎 to provide feedback.

Debug

Playground

- run: python -m pytest tests/ -v --tb=short 2>&1 || true
Copy link
Copy Markdown

@beta-devin-ai-integration beta-devin-ai-integration Bot Apr 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 || true suppresses all test failures, making CI always pass

The pytest command ends with || true, which forces the step to exit with code 0 regardless of whether tests pass or fail. This completely defeats the purpose of a CI pipeline — broken code will never be caught. The || true should be removed so that test failures are properly reported.

Suggested change
- run: python -m pytest tests/ -v --tb=short 2>&1 || true
- run: python -m pytest tests/ -v --tb=short
Staging: Open in Devin

Was this helpful? React with 👍 or 👎 to provide feedback.

Debug

Playground

Comment thread
beta-devin-ai-integration[bot] marked this conversation as resolved.
Loading