Open
Conversation
- Item Codex core - Codex collections with Character/Limited/Event buckets. - Time windows (Start/End, server-local), with KeepStatsAfterExpiry. - JSON-first persistence (`Configs/ItemCodex.json`) with `_meta` (version/timeBasis); legacy INI/legacy text still loadable. - Server sync now includes Active/KeepStats/start/end ticks; submissions/claims gated by window; keep-stats preserves bonuses after expiry; expired sets without keep are hidden and blocked. - Client UI shows active/unstarted/expired states; Event tab is wired; counters/bars include Event; rows show time hints and grey when inactive; scroll reset fixed. - Editor updates: Start/End/Keep fields for Limited/Event, validation (Start < End), 30-min snapping, bucket change prompt, bucket filter (All/Character/Limited/Event), JSON import/export, guard against zero-item saves. - Currencies (Codex) - Currency enum includes Jade/Stone. UI shows Stone/Jade labels; Codex dialog has currency labels; unused currencies removed from currency list dialog. - Stats - Stat enum includes MinDamage/MaxDamage and Strength/Intelligence/Endurance/WillPower. - Pretty stat names updated; rewards display merged min/max pairs. - Keep-stats honored in stat application: completed collections with keep-stats still apply after expiry; expired without keep are removed.
- Codex now loads/saves JSON only; TXT/INI and auto-build fallback removed. - Removed @codex GM commands (export/reload/complete/clear); @completecodex <id> remains. - Codex editor UI hides import/export buttons and related hotkeys; save/load is JSON-only. - Saving codex skips empty collections (no blocking popup); autosave still writes non-empty sets. - Updated codex localization strings to reference JSON paths.
Contributor
|
hi far |
Contributor
Author
|
This is a rather big system and needs live testing and further improvements to keep up-to Fars standards of keeping the master source viable. |
Owner
|
Yes i would like to accept obviously, however theres a lot of code so having the time to go through it all and feedback will be a while. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Suprcode , your not going to enjoy this one. Probably lots of Improvements required 👍 System pretty much works like KR Version from what i have seen and tested.
Item Codex core
Configs/ItemCodex.json) with_meta(version/timeBasis); legacy INI/legacy text still loadable.Currencies (Codex)
Stats
Allow Item Codex permission added to Config.
Item Codex editor location.
Item Codex Editor
Category, You can select between Character = Perm, Limited and Event, Limited and Event have the capability to Date, Time selection and keep stats after expiry.
Stat reward window.

Codex item selection form, you can either double click the item or use add selection button.
orReward](https://github.com/user-attachments/assets/32e3bdc3-4f3e-4ee0-8278-4def2098d63e)
Currency window added, Clicking gold image inside the Inventory window will open this window. Idea taken from Mir3
Main ItemCodex window. default opens Archive (Character Perm) below is also Limited, and Event, Timed codex is shown. Please note each Codex box will only allow 3x lines due to font, size. If you have multiple lines, a hint message will appear.
**Codex Level and Claimed stat bonus icons both display hints as per KR **
Once you have obtained a required Item, it will apply a indication and submit button, (KR only allows this once complete set is inside inventory.)
Once you have submitted an item it will leave a mark.
And once codex is complete it will leave a complete label as per KR
Collection complete animation will play as per KR, there is also an animation for Codex Levelup
Stats will show in both appear inhint.
Theres is also a reward stat list.
Filter by stats & rarity type. (KR only offer rarity of Rare & Legendary)
Source information.
(my own KR Account)
https://www.youtube.com/watch?v=3ucgAw5gOcc
https://mir2.mironline.co.kr/dic/dicView?depth1=118&depth2=213&depth3=0