Open
Conversation
Rarity Colour's can now be changed inside the MonsterRarity.ini Default is now set False. MonsterInfoFormNew IsBoss bool now restricts from spawning enhanced rarity.
Suprcode
requested changes
Dec 23, 2025
Owner
Suprcode
left a comment
Suprcode
left a comment
There was a problem hiding this comment.
Wrong color translator used.
This whole system would be cleaner if it didn't have hard coded variables for each rarity and instead just had a multiplier for the default values.
It already does this mostly for the profiles, it just needs the hard coded variables for the defaults removing, and instead for each rarity just increase by a certain amount. Once the defaults are set it then just reads from the config anyway.
Server/Settings.cs
Outdated
|
|
||
| try | ||
| { | ||
| Color parsed = ColorTranslator.FromHtml(value); |
| return percent; | ||
| } | ||
|
|
||
| public static void SaveMonsterRarity() |
Owner
There was a problem hiding this comment.
Lots of values missing here not being saved. Everything that's loaded should also be saved.
1. Custom rarity names. Defaults "Uncommon, Rare, Elite 2. Stat increase toggle for each rarity can be TRUE/FALSE inside MonsterRarity.ini 3. Summon Pets bug prevented. 4. changes to Color.FromName
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rarity Colour's can now be changed inside the MonsterRarity.ini
Default is now set False.
MonsterInfoFormNew IsBoss bool now restricts from spawning enhanced rarity.