Skip to content

Merge remote-tracking branch 'origin/main' into fix/input-action-origins-binding-info#320

Open
nokichan wants to merge 8 commits intoSupreeeme:mainfrom
nokichan:fix/input-action-origins-binding-info
Open

Merge remote-tracking branch 'origin/main' into fix/input-action-origins-binding-info#320
nokichan wants to merge 8 commits intoSupreeeme:mainfrom
nokichan:fix/input-action-origins-binding-info

Conversation

@nokichan
Copy link
Copy Markdown

@nokichan nokichan commented Mar 5, 2026

This PR solves the #162 issue

@nokichan nokichan marked this pull request as draft March 5, 2026 18:27
@nokichan nokichan force-pushed the fix/input-action-origins-binding-info branch 2 times, most recently from 8db1695 to b5aabb1 Compare March 5, 2026 19:17
@nokichan nokichan force-pushed the fix/input-action-origins-binding-info branch from b5aabb1 to dd87c9c Compare March 5, 2026 19:51
@nokichan nokichan marked this pull request as ready for review March 5, 2026 20:33
@Abyss-c0re
Copy link
Copy Markdown

I've tried to test, but seems like NMS is not launching in VR mode again :(

@nokichan
Copy link
Copy Markdown
Author

nokichan commented Mar 7, 2026

I've tried to test, but seems like NMS is not launching in VR mode again :(

Not sure if this could help, but in the General Options of No Man's Sky on Steam I've added these options:
PROTON_ENABLE_NVAPI=1 DXVK_ASYNC=1 %command% -HmdEnable 1

And to tackle this VR problem I think that is related with the Proton version. I've changed the Proton version in the compatibility tab to the Proton-CachyOS one

@Abyss-c0re
Copy link
Copy Markdown

I've tried to test, but seems like NMS is not launching in VR mode again :(

Not sure if this could help, but in the General Options of No Man's Sky on Steam I've added these options: PROTON_ENABLE_NVAPI=1 DXVK_ASYNC=1 %command% -HmdEnable 1

And to tackle this VR problem I think that is related with the Proton version. I've changed the Proton version in the compatibility tab to the Proton-CachyOS one

Thanks to reply. My nms broke after I switch to CachyOS. Some time I go it was fixed with nightly xrizer and experimental branch, but seems like some update broke it again.

My current launch options are following.

PRESSURE_VESSEL_IMPORT_OPENXR_1_RUNTIMES=1 PRESSURE_VESSEL_FILESYSTEMS_RW=/var/lib/flatpak/app/io.github.wivrn.wivrn VR_OVERRIDE=$HOME/Games/xrizer_fixed/target/release PROTON_ENABLE_NVAPI=1 DXVK_ASYNC=1 %command% -HmdEnable 1

@nokichan
Copy link
Copy Markdown
Author

I've tried to test, but seems like NMS is not launching in VR mode again :(

Not sure if this could help, but in the General Options of No Man's Sky on Steam I've added these options: PROTON_ENABLE_NVAPI=1 DXVK_ASYNC=1 %command% -HmdEnable 1
And to tackle this VR problem I think that is related with the Proton version. I've changed the Proton version in the compatibility tab to the Proton-CachyOS one

Thanks to reply. My nms broke after I switch to CachyOS. Some time I go it was fixed with nightly xrizer and experimental branch, but seems like some update broke it again.

My current launch options are following.

PRESSURE_VESSEL_IMPORT_OPENXR_1_RUNTIMES=1 PRESSURE_VESSEL_FILESYSTEMS_RW=/var/lib/flatpak/app/io.github.wivrn.wivrn VR_OVERRIDE=$HOME/Games/xrizer_fixed/target/release PROTON_ENABLE_NVAPI=1 DXVK_ASYNC=1 %command% -HmdEnable 1

As you are using flatpak, honestly no idea how it handles flatpak with a compiled version outside flatpak of this xrizer module, I have steam, xrizer and Wivrn installed "directly", no flatpak around.

Did you think about permissions in the involved flatpak packages that are you using to try to run the game?

@Abyss-c0re
Copy link
Copy Markdown

Alright , today NMS randomly started, I guess another experimental NMS update fixed it, however I still see ⚠️ everywhere instead of controller glyphs.

For the sake of experiment I replaced the flatpak WinVRn version with the one from Arch repo , but it didn't change anything. I am pretty sure it uses build from your PR , as I don't have any other instances of xrizer installed (wivrn even issued a warning about it)

@Supreeeme
Copy link
Copy Markdown
Owner

I'm currently working on a refactor of the way input profiles work, I'm going to wait to review this until that is done.

@pulsipd
Copy link
Copy Markdown

pulsipd commented Mar 16, 2026

I cherry picked these PR implementation commits and rebuilt the library and ran NSM with proper glyphs as expected. I was previously having the missing glyph issue on main. Looks good to me, but I did have to tweak his input.rs sytax on a couple of lines to get it building.

@nokichan
Copy link
Copy Markdown
Author

I cherry picked these PR implementation commits and rebuilt the library and ran NSM with proper glyphs as expected. I was previously having the missing glyph issue on main. Looks good to me, but I did have to tweak his input.rs sytax on a couple of lines to get it building.

Thanks for your reply and testing!

Which tweaks did you do to fix it? Maybe I can implement this tweaks to make it work to everyone

@pulsipd
Copy link
Copy Markdown

pulsipd commented Mar 19, 2026

Here is my patch that got their PR to build for me (see attached)-
skeleton-pattern-fix.patch

@pulsipd
Copy link
Copy Markdown

pulsipd commented Mar 19, 2026

I cherry picked these PR implementation commits and rebuilt the library and ran NSM with proper glyphs as expected. I was previously having the missing glyph issue on main. Looks good to me, but I did have to tweak his input.rs sytax on a couple of lines to get it building.

Thanks for your reply and testing!

Which tweaks did you do to fix it? Maybe I can implement this tweaks to make it work to everyone

I just want to say thanks for your work on this project, because of this library I was able to pull the trigger and finally move off of windows completely.

@Abyss-c0re
Copy link
Copy Markdown

**pulsipd **
Works for me now, thanks for the path. I synced with the main.

https://github.com/Abyss-c0re/xrizer

@nokichan , Would you like to update your PR, or should I do the honors?

@nokichan
Copy link
Copy Markdown
Author

I've updated the suggested changes and tested, I see that it works properly. Thanks @pulsipd @Abyss-c0re !

@Abyss-c0re
Copy link
Copy Markdown

I've updated the suggested changes and tested, I see that it works properly. Thanks @pulsipd @Abyss-c0re !

Thank you as well, I now can now enjoy nms at a higher resolution without compromises!

@AntiApple4life
Copy link
Copy Markdown

I was able to get it fully working on no man's sky without issue, but this pr still doesn't work for vrchat:
image

@nokichan
Copy link
Copy Markdown
Author

nokichan commented Apr 2, 2026

I was able to get it fully working on no man's sky without issue, but this pr still doesn't work for vrchat

Hi @AntiApple4life, I didn't create this PR testing VRChat, but after the merge I can try to install it in my machine and take a look

@pedro-moser
Copy link
Copy Markdown

Tested on Quest 3 + WiVRn with No Man's Sky (64-bit, Proton). This PR fixes the missing controller glyph issue tracked in #339 — glyphs render correctly after building this branch. No regressions observed so far in basic gameplay/menu interaction. +1 for merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants