feat: Porting from WebRTC to LiveKit#49
Open
costomato wants to merge 1 commit intoSuyious:feature/livekit-videofrom
Open
feat: Porting from WebRTC to LiveKit#49costomato wants to merge 1 commit intoSuyious:feature/livekit-videofrom
costomato wants to merge 1 commit intoSuyious:feature/livekit-videofrom
Conversation
👷 Deploy request for purrrchat pending review.Visit the deploys page to approve it
|
|
@costomato is attempting to deploy a commit to the suyious' projects Team on Vercel. A member of the Team first needs to authorize it. |
Suyious
reviewed
Jun 5, 2025
| message: string, | ||
| sharedSecret: CryptoKey, | ||
| isImage: boolean = false | ||
| isImage: Boolean = false |
Owner
There was a problem hiding this comment.
Do you have any reason for changing primitive boolean to the Boolean class?
Suyious
reviewed
Jun 5, 2025
| } catch (error) { | ||
| console.error("Failed to start LiveKit call:", error); | ||
| alert("Could not start video call"); | ||
| } |
Owner
There was a problem hiding this comment.
Will have to test this functionality. For now, is this in a working state or does it need more work before that?
Suyious
reviewed
Jun 5, 2025
| "lint": "next lint" | ||
| }, | ||
| "dependencies": { | ||
| "@daily-co/daily-react": "^0.22.0", |
Owner
There was a problem hiding this comment.
Is @daily-co/daily-react library being used anywhere or is it redundant? What about @livekit/components-react and @livekit/components-styles??
Suyious
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Video Calling Implementation attempting to replace current WebRTC implementation. Used livekit.io for more reliable Video Calling.
Attempting #50