Skip to content

Autoformatting with github actions#64

Merged
GreatGreenStar merged 44 commits into
mainfrom
auto-format-prs
Feb 24, 2026
Merged

Autoformatting with github actions#64
GreatGreenStar merged 44 commits into
mainfrom
auto-format-prs

Conversation

@GreatGreenStar
Copy link
Copy Markdown
Contributor

This will allow manual build validation and code format checks, to use as desired.

When code is pushed or a pull request is made, said code will now be checked for if formatted properly. If code is NOT formatted properly, it will trigger another action which DOES format it properly and commits the fix to do so.

@GreatGreenStar GreatGreenStar self-assigned this Feb 23, 2026
@GreatGreenStar GreatGreenStar marked this pull request as ready for review February 23, 2026 02:22
@GreatGreenStar GreatGreenStar added enhancement New feature or request help wanted Extra attention is needed labels Feb 23, 2026
@github-project-automation github-project-automation Bot moved this to Backlog in Rebuilt Feb 23, 2026
@GreatGreenStar GreatGreenStar moved this from Backlog to In review in Rebuilt Feb 23, 2026
@GreatGreenStar GreatGreenStar marked this pull request as draft February 23, 2026 02:29
@GreatGreenStar GreatGreenStar marked this pull request as ready for review February 23, 2026 02:34
@GreatGreenStar GreatGreenStar marked this pull request as draft February 23, 2026 02:37
@GreatGreenStar GreatGreenStar marked this pull request as ready for review February 23, 2026 02:40
@GreatGreenStar
Copy link
Copy Markdown
Contributor Author

Note that after code is formatted by spotless, it will for a moment hide the checks because it cannot run against itself per https://github.com/marketplace/actions/add-commit#the-commit-from-the-action-is-not-triggering-ci
Fixing would add needless complexity, as you can simply look at the last human commit. Further, it should still block/allow based off the last checks against a human, so blocking commits that don't build should still work in full.

@GreatGreenStar
Copy link
Copy Markdown
Contributor Author

For most of the times I quickly made multiple commits in under a minute I let copilot generate the commit message so a lot of the "in-a-row" commits are... questionable. that said, I assert that given my above comment about checks appearing to partially vanish under certain conditions and how they don't in actuality, this works.

GreatGreenStar and others added 24 commits February 23, 2026 20:46
This should in theory be faster and work.
Comment out spotless check and success condition for commit.
Failsafe, so it checks regardless
This file is created to prevent empty commits.
In theory, the commit code should only run if spotless was applied, which should only occur if check fails.
Just so I don't change anything that doesn't need it
@GreatGreenStar GreatGreenStar merged commit 9363319 into main Feb 24, 2026
@GreatGreenStar GreatGreenStar deleted the auto-format-prs branch February 24, 2026 02:50
@github-project-automation github-project-automation Bot moved this from In review to Done in Rebuilt Feb 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request help wanted Extra attention is needed

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants